From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9JXp-0007ce-Tn for qemu-devel@nongnu.org; Tue, 22 Nov 2016 17:28:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9JXn-000312-9f for qemu-devel@nongnu.org; Tue, 22 Nov 2016 17:28:05 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33742) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9JXn-00030J-2z for qemu-devel@nongnu.org; Tue, 22 Nov 2016 17:28:03 -0500 Received: by mail-wm0-x243.google.com with SMTP id u144so7158488wmu.0 for ; Tue, 22 Nov 2016 14:28:02 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 22 Nov 2016 23:27:56 +0100 Message-Id: <1479853676-35995-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1479853676-35995-1-git-send-email-pbonzini@redhat.com> References: <1479853676-35995-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 3/3] scsi/esp: do not raise an interrupt when reading the FIFO register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= From: Hervé Poussineau This fixes SCSI adapter self-tests done in MIPS Jazz emulation, broken since ff589551c8e8e9e95e211b9d8daafb4ed39f1aec. Signed-off-by: Hervé Poussineau Message-Id: <1479508397-8443-1-git-send-email-hpoussin@reactos.org> Signed-off-by: Paolo Bonzini --- hw/scsi/esp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 1f2f2d3..5a5a4e9 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -406,11 +406,9 @@ uint64_t esp_reg_read(ESPState *s, uint32_t saddr) /* Data out. */ qemu_log_mask(LOG_UNIMP, "esp: PIO data read not implemented\n"); s->rregs[ESP_FIFO] = 0; - esp_raise_irq(s); } else if (s->ti_rptr < s->ti_wptr) { s->ti_size--; s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++]; - esp_raise_irq(s); } if (s->ti_rptr == s->ti_wptr) { s->ti_rptr = 0; -- 1.8.3.1