qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org, stefanha@redhat.com
Cc: agraf@suse.de, mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 01/11] tests/postcopy: Use KVM on ppc64 only if it is KVM-HV
Date: Wed, 23 Nov 2016 13:49:33 +1100	[thread overview]
Message-ID: <1479869383-16162-2-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1479869383-16162-1-git-send-email-david@gibson.dropbear.id.au>

From: Thomas Huth <thuth@redhat.com>

The ppc64 postcopy test does not work with KVM-PR, and it is also
causing annoying warning messages when run on a x86 host. So let's
use KVM here only if we know that we're running with KVM-HV (which
automatically also means that we're running on a ppc64 host), and
fall back to TCG otherwise.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 tests/postcopy-test.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
index d6613c5..dafe8be 100644
--- a/tests/postcopy-test.c
+++ b/tests/postcopy-test.c
@@ -380,17 +380,21 @@ static void test_migrate(void)
                                   " -incoming %s",
                                   tmpfs, bootpath, uri);
     } else if (strcmp(arch, "ppc64") == 0) {
+        const char *accel;
+
+        /* On ppc64, the test only works with kvm-hv, but not with kvm-pr */
+        accel = access("/sys/module/kvm_hv", F_OK) ? "tcg" : "kvm:tcg";
         init_bootfile_ppc(bootpath);
-        cmd_src = g_strdup_printf("-machine accel=kvm:tcg -m 256M"
+        cmd_src = g_strdup_printf("-machine accel=%s -m 256M"
                                   " -name pcsource,debug-threads=on"
                                   " -serial file:%s/src_serial"
                                   " -drive file=%s,if=pflash,format=raw",
-                                  tmpfs, bootpath);
-        cmd_dst = g_strdup_printf("-machine accel=kvm:tcg -m 256M"
+                                  accel, tmpfs, bootpath);
+        cmd_dst = g_strdup_printf("-machine accel=%s -m 256M"
                                   " -name pcdest,debug-threads=on"
                                   " -serial file:%s/dest_serial"
                                   " -incoming %s",
-                                  tmpfs, uri);
+                                  accel, tmpfs, uri);
     } else {
         g_assert_not_reached();
     }
-- 
2.7.4

  reply	other threads:[~2016-11-23  2:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23  2:49 [Qemu-devel] [PULL 00/11] ppc-for-2.8 queue 20161123 David Gibson
2016-11-23  2:49 ` David Gibson [this message]
2016-11-23  2:49 ` [Qemu-devel] [PULL 02/11] spapr: migration support for CAS-negotiated option vectors David Gibson
2016-11-23  2:49 ` [Qemu-devel] [PULL 03/11] ppc: BOOK3E: nothing should be done when MSR:PR is set David Gibson
2016-11-23  2:49 ` [Qemu-devel] [PULL 04/11] hw/char/spapr_vty: Return amount of free buffer entries in vty_can_receive() David Gibson
2016-11-23  2:49 ` [Qemu-devel] [PULL 05/11] target-ppc: fix index array of national digits David Gibson
2016-11-23  2:49 ` [Qemu-devel] [PULL 06/11] ppc: Make uninorth interrupt swizzling identical to Grackle David Gibson
2016-11-23  2:49 ` [Qemu-devel] [PULL 07/11] target-ppc: Fix CPU migration from qemu-2.6 <-> later versions David Gibson
2016-11-23  5:10   ` David Gibson
2016-11-23  6:04     ` Michael Roth
2016-11-23  2:49 ` [Qemu-devel] [PULL 08/11] migration: Add VMSTATE_UINTTL_TEST() David Gibson
2016-11-23  2:49 ` [Qemu-devel] [PULL 09/11] target-ppc: Allow eventual removal of old migration mistakes David Gibson
2016-11-23  2:49 ` [Qemu-devel] [PULL 10/11] Revert "spapr: Fix migration of PCI host bridges from qemu-2.7" David Gibson
2016-11-23  2:49 ` [Qemu-devel] [PULL 11/11] spapr: Fix 2.7<->2.8 migration of PCI host bridge David Gibson
2016-11-23  3:06 ` [Qemu-devel] [PULL 00/11] ppc-for-2.8 queue 20161123 no-reply
2016-11-24  9:50   ` Stefan Hajnoczi
2016-11-24 22:12     ` David Gibson
2016-11-23 11:50 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479869383-16162-2-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).