From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: programmingkidx@gmail.com, armbru@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH for-2.8 0/3] Fix MacOS runtime failure of qobject_from_jsonf()
Date: Tue, 22 Nov 2016 22:16:25 -0600 [thread overview]
Message-ID: <1479874588-1969-1-git-send-email-eblake@redhat.com> (raw)
programmingkidx@gmail.com[*] reported a runtime failure on a
32-bit Mac OS compilation, where "%"PRId64 expands to "%qd".
Fortunately, we had very few spots that were relying on our
pseudo-printf JSON parsing of 64-bit numbers, so it was
easier to just convert callers and rip out the 64-bit support.
The remaining uses of pseudo-printf handling are more complex;
there are only 3 users in the released codebased, but LOTS of
users in the testsuite (via wrapper functions like qmp()); I
will be posting a followup series that rips out the remaining
uses of dynamic JSON, but it will be 2.9 material, while
these three patches qualify for 2.8.
[*] git log shows the name John, but the particular email that
sparked this only stated the non-descript name 'G 3', which
makes it a bit hard for me to know which form is preferred
when lending credit.
In patch 3, I chose to remove existing support for 64-bit
dynamic JSON on all platforms, so that we quickly see a failure
in an attempt to use such a construct even on mainstream glibc
development environments, rather than only on the less-frequent
32-bit Mac OS build environment.
Eric Blake (3):
qmp-event: Avoid qobject_from_jsonf("%"PRId64)
test-qga: Avoid qobject_from_jsonf("%"PRId64)
qapi: Drop support for qobject_from_jsonf("%"PRId64)
qapi/qmp-event.c | 12 +++++++-----
qobject/json-lexer.c | 28 ----------------------------
qobject/json-parser.c | 5 -----
tests/check-qjson.c | 10 ----------
tests/test-qga.c | 9 +++++++--
tests/test-qobject-input-visitor.c | 5 +++--
6 files changed, 17 insertions(+), 52 deletions(-)
--
2.7.4
next reply other threads:[~2016-11-23 4:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 4:16 Eric Blake [this message]
2016-11-23 4:16 ` [Qemu-devel] [PATCH 1/3] qmp-event: Avoid qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-23 13:45 ` Markus Armbruster
2016-11-23 13:56 ` Eric Blake
2016-11-23 14:04 ` Eric Blake
2016-11-23 4:16 ` [Qemu-devel] [PATCH 2/3] test-qga: " Eric Blake
2016-11-23 9:23 ` Paolo Bonzini
2016-11-23 10:36 ` Eric Blake
2016-11-23 11:08 ` Eric Blake
2016-11-23 12:06 ` Paolo Bonzini
2016-11-23 14:05 ` Markus Armbruster
2016-11-23 14:14 ` Eric Blake
2016-11-23 16:55 ` Markus Armbruster
2016-11-23 4:16 ` [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-23 9:25 ` Paolo Bonzini
2016-11-23 10:54 ` Eric Blake
2016-11-23 14:17 ` Markus Armbruster
2016-11-23 14:24 ` Eric Blake
2016-11-23 16:56 ` Markus Armbruster
2016-11-23 16:59 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479874588-1969-1-git-send-email-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).