[Qemu-devel] [PULL for-2.8] target-alpha: fix smp interrupts

[Qemu-devel] [PULL for-2.8] target-alpha: fix smp interrupts

[Richard Henderson]

This is such a minor typo, let's fix it for 2.8 please.


r~

The following changes since commit c36ed06e9159fa484b711dfdd27ec64d7ac3d17a:

  Merge remote-tracking branch 'mst/tags/for_upstream' into staging (2016-11-21 11:09:58 +0000)

are available in the git repository at:

  git://github.com/rth7680/qemu.git tags/pull-axp-20161123

for you to fetch changes up to 424ad8388f89f4202a7836d003273f23ebe04b09:

  target-alpha: Fix interrupt mask for cpu1 (2016-11-22 16:53:53 +0100)

----------------------------------------------------------------
Fix alpha smp interrupt masking

----------------------------------------------------------------
Richard Henderson (1):
      target-alpha: Fix interrupt mask for cpu1

 hw/alpha/typhoon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL for-2.8] target-alpha: Fix interrupt mask for cpu1

[Richard Henderson]

A typo prevents ISA interrupts from being recognized on cpu0,
which is where the smp kernel normally wants to see them.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 hw/alpha/typhoon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c
index 883db13..f50f5cf 100644
--- a/hw/alpha/typhoon.c
+++ b/hw/alpha/typhoon.c
@@ -376,7 +376,7 @@ static void cchip_write(void *opaque, hwaddr addr,
         break;
     case 0x0240: /* DIM1 */
         /* DIM: Device Interrupt Mask Register, CPU1.  */
-        s->cchip.dim[0] = val;
+        s->cchip.dim[1] = val;
         cpu_irq_change(s->cchip.cpu[1], val & s->cchip.drir);
         break;
 
-- 
2.7.4

Re: [Qemu-devel] [PULL for-2.8] target-alpha: fix smp interrupts

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

On Wed, Nov 23, 2016 at 01:46:34PM +0100, Richard Henderson wrote:
> This is such a minor typo, let's fix it for 2.8 please.
> 
> 
> r~
> 
> The following changes since commit c36ed06e9159fa484b711dfdd27ec64d7ac3d17a:
> 
>   Merge remote-tracking branch 'mst/tags/for_upstream' into staging (2016-11-21 11:09:58 +0000)
> 
> are available in the git repository at:
> 
>   git://github.com/rth7680/qemu.git tags/pull-axp-20161123
> 
> for you to fetch changes up to 424ad8388f89f4202a7836d003273f23ebe04b09:
> 
>   target-alpha: Fix interrupt mask for cpu1 (2016-11-22 16:53:53 +0100)
> 
> ----------------------------------------------------------------
> Fix alpha smp interrupt masking
> 
> ----------------------------------------------------------------
> Richard Henderson (1):
>       target-alpha: Fix interrupt mask for cpu1
> 
>  hw/alpha/typhoon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]