* [Qemu-devel] [PATCH for-2.8] target-m68k: fix EXG instruction
@ 2016-11-23 16:37 Laurent Vivier
2016-11-23 18:05 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Vivier @ 2016-11-23 16:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Laurent Vivier
opcodes of "EXG Ax,Ay" and "EXG Dx,Dy" have been swapped
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
target-m68k/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index 9ad974f..8e522db 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -2198,13 +2198,13 @@ static void do_exg(TCGv reg1, TCGv reg2)
tcg_temp_free(temp);
}
-DISAS_INSN(exg_aa)
+DISAS_INSN(exg_dd)
{
/* exchange Dx and Dy */
do_exg(DREG(insn, 9), DREG(insn, 0));
}
-DISAS_INSN(exg_dd)
+DISAS_INSN(exg_aa)
{
/* exchange Ax and Ay */
do_exg(AREG(insn, 9), AREG(insn, 0));
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.8] target-m68k: fix EXG instruction
2016-11-23 16:37 [Qemu-devel] [PATCH for-2.8] target-m68k: fix EXG instruction Laurent Vivier
@ 2016-11-23 18:05 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2016-11-23 18:05 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel
On 11/23/2016 05:37 PM, Laurent Vivier wrote:
> opcodes of "EXG Ax,Ay" and "EXG Dx,Dy" have been swapped
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target-m68k/translate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Whoops. ;-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-23 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 16:37 [Qemu-devel] [PATCH for-2.8] target-m68k: fix EXG instruction Laurent Vivier
2016-11-23 18:05 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).