From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9bTg-0000Ww-HT for qemu-devel@nongnu.org; Wed, 23 Nov 2016 12:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9bTf-0001ll-Rz for qemu-devel@nongnu.org; Wed, 23 Nov 2016 12:37:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9bTf-0001kq-My for qemu-devel@nongnu.org; Wed, 23 Nov 2016 12:36:59 -0500 From: Eric Blake Date: Wed, 23 Nov 2016 11:36:53 -0600 Message-Id: <1479922617-4400-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: programmingkidx@gmail.com, armbru@redhat.com, pbonzini@redhat.com programmingkidx@gmail.com[*] reported a runtime failure on a 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd". Fortunately, we had very few spots that were relying on our pseudo-printf JSON parsing of int64_t numbers, so it was easier to just convert callers to stick to safer %lld. The remaining uses of pseudo-printf handling are more complex; there are only 3 users in the released codebased, but LOTS of users in the testsuite (via wrapper functions like qmp()); I will be posting a followup series that rips out the remaining uses of dynamic JSON, but it will be 2.9 material, while these (first three) patches qualify for 2.8. The fourth patch is RFC; not intended to be applied now, but shows how I tested patch 3/4; it will probably reappear in the later 2.9 series. [*] git log shows the name John, but the particular email that sparked this only stated the non-descript name 'G 3', which makes it a bit hard for me to know which form is preferred when lending credit. Eric Blake (4): qmp-event: Avoid qobject_from_jsonf("%"PRId64) test-qga: Avoid qobject_from_jsonv("%"PRId64) tests: Avoid qobject_from_jsonf("%"PRId64) RFC: qapi: Drop support for qobject_from_jsonf("%"PRId64) qapi/qmp-event.c | 17 ++++------------- qobject/json-lexer.c | 17 ----------------- qobject/json-parser.c | 9 ++++----- tests/check-qjson.c | 4 ++-- tests/test-qga.c | 7 +++++-- tests/test-qobject-input-visitor.c | 5 +++-- 6 files changed, 18 insertions(+), 41 deletions(-) -- 2.7.4