qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()
@ 2016-11-23 17:36 Eric Blake
  2016-11-23 17:36 ` [Qemu-devel] [PATCH v2 1/4] qmp-event: Avoid qobject_from_jsonf("%"PRId64) Eric Blake
                   ` (6 more replies)
  0 siblings, 7 replies; 15+ messages in thread
From: Eric Blake @ 2016-11-23 17:36 UTC (permalink / raw)
  To: qemu-devel; +Cc: programmingkidx, armbru, pbonzini

programmingkidx@gmail.com[*] reported a runtime failure on a
32-bit Mac OS compilation, where "%"PRId64 expands to "%qd".
Fortunately, we had very few spots that were relying on our
pseudo-printf JSON parsing of int64_t numbers, so it was
easier to just convert callers to stick to safer %lld.

The remaining uses of pseudo-printf handling are more complex;
there are only 3 users in the released codebased, but LOTS of
users in the testsuite (via wrapper functions like qmp()); I
will be posting a followup series that rips out the remaining
uses of dynamic JSON, but it will be 2.9 material, while
these (first three) patches qualify for 2.8.  The fourth patch
is RFC; not intended to be applied now, but shows how I tested
patch 3/4; it will probably reappear in the later 2.9 series.

[*] git log shows the name John, but the particular email that
sparked this only stated the non-descript name 'G 3', which
makes it a bit hard for me to know which form is preferred
when lending credit.

Eric Blake (4):
  qmp-event: Avoid qobject_from_jsonf("%"PRId64)
  test-qga: Avoid qobject_from_jsonv("%"PRId64)
  tests: Avoid qobject_from_jsonf("%"PRId64)
  RFC: qapi: Drop support for qobject_from_jsonf("%"PRId64)

 qapi/qmp-event.c                   | 17 ++++-------------
 qobject/json-lexer.c               | 17 -----------------
 qobject/json-parser.c              |  9 ++++-----
 tests/check-qjson.c                |  4 ++--
 tests/test-qga.c                   |  7 +++++--
 tests/test-qobject-input-visitor.c |  5 +++--
 6 files changed, 18 insertions(+), 41 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2016-12-05 16:55 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 17:36 [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf() Eric Blake
2016-11-23 17:36 ` [Qemu-devel] [PATCH v2 1/4] qmp-event: Avoid qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-24 11:00   ` Markus Armbruster
2016-11-24 16:34     ` Eric Blake
2016-11-23 17:36 ` [Qemu-devel] [PATCH v2 2/4] test-qga: Avoid qobject_from_jsonv("%"PRId64) Eric Blake
2016-11-23 17:36 ` [Qemu-devel] [PATCH v2 3/4] tests: Avoid qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-24 11:03   ` Markus Armbruster
2016-11-23 17:36 ` [Qemu-devel] [PATCH v2 4/4] RFC: qapi: Drop support for qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-24 11:07 ` [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf() Markus Armbruster
2016-11-24 16:32   ` Eric Blake
2016-11-25  8:59     ` Markus Armbruster
2016-11-25 11:56   ` Stefan Hajnoczi
2016-11-29  8:20 ` no-reply
2016-11-29  9:33   ` Markus Armbruster
2016-12-05 16:55 ` Markus Armbruster

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).