* [Qemu-devel] [PATCH for-2.8] target-m68k: fix muluw/mulsw
@ 2016-11-24 8:40 Laurent Vivier
2016-11-24 9:42 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Vivier @ 2016-11-24 8:40 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Laurent Vivier
"The multiplier and multiplicand are both word operands, and the result
is a long-word operand."
So compute flags on a long-word result, not on a word result.
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
target-m68k/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index d2d6816..d6ed883 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -1186,7 +1186,7 @@ DISAS_INSN(mulw)
SRC_EA(env, src, OS_WORD, sign, NULL);
tcg_gen_mul_i32(tmp, tmp, src);
tcg_gen_mov_i32(reg, tmp);
- gen_logic_cc(s, tmp, OS_WORD);
+ gen_logic_cc(s, tmp, OS_LONG);
}
DISAS_INSN(divw)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.8] target-m68k: fix muluw/mulsw
2016-11-24 8:40 [Qemu-devel] [PATCH for-2.8] target-m68k: fix muluw/mulsw Laurent Vivier
@ 2016-11-24 9:42 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2016-11-24 9:42 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel
On 11/24/2016 09:40 AM, Laurent Vivier wrote:
> "The multiplier and multiplicand are both word operands, and the result
> is a long-word operand."
>
> So compute flags on a long-word result, not on a word result.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target-m68k/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-24 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 8:40 [Qemu-devel] [PATCH for-2.8] target-m68k: fix muluw/mulsw Laurent Vivier
2016-11-24 9:42 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).