qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Kevin O'Connor <kevin@koconnor.net>,
	qemu devel list <qemu-devel@nongnu.org>,
	Igor Mammedov <imammedo@redhat.com>,
	"Jordan Justen (Intel address)" <jordan.l.justen@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>
Subject: Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI
Date: Mon, 28 Nov 2016 10:01:57 +0100	[thread overview]
Message-ID: <1480323717.20061.27.camel@redhat.com> (raw)
In-Reply-To: <6f8e7da4-b581-9bf2-9209-4100c591c7a6@redhat.com>

  Hi,

> If I understand correctly, one argument against the current state of
> writeable fw_cfg, captured in
> <https://www.mail-archive.com/qemu-devel@nongnu.org/msg354983.html>, is
> that callbacks on write are not supported. Apparently, QEMU code that
> uses the data written by the guest is supposed to just read that data,
> not to expect a notification about it.
> 
> I'm unsure how this can work for actual negotiation, where the guest
> usually does a read/write/read cycle, and expects some kind of change
> between steps #2 and #3. I don't see how that can be implemented in QEMU
> without write callbacks (i.e. how QEMU can confirm or reject the
> negotiation attempt).

Do you actually need negotiation?  I think you only need to know
whenever broadcast-smi is supported, and the presence of the
etc/broadcast-smi (or however we name that) fw_cfg file indicates that.
If it is there just write true/false to it to enable/disable, and qemu
checks the field each time a smi is raised.

cheers,
  Gerd

  reply	other threads:[~2016-11-28  9:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 10:36 [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI Laszlo Ersek
2016-11-18 10:36 ` [Qemu-devel] [PATCH v3 for-2.9 1/3] hw/isa/apm: introduce callback for APM_STS_IOPORT writes Laszlo Ersek
2016-11-18 10:36 ` [Qemu-devel] [PATCH v3 for-2.9 2/3] hw/isa/lpc_ich9: add SMI feature negotiation via APM_STS Laszlo Ersek
2016-11-18 10:36 ` [Qemu-devel] [PATCH v3 for-2.9 3/3] hw/isa/lpc_ich9: ICH9_APM_STS_F_BROADCAST_SMI: inject SMI on all VCPUs Laszlo Ersek
2016-11-18 14:10 ` [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI Michael S. Tsirkin
2016-11-23 15:48   ` Laszlo Ersek
2016-11-23 22:35 ` Paolo Bonzini
2016-11-24  0:01   ` Laszlo Ersek
2016-11-24  0:31     ` Laszlo Ersek
2016-11-24  0:38     ` Kevin O'Connor
2016-11-24  4:29       ` Michael S. Tsirkin
2016-11-24  8:37         ` Laszlo Ersek
2016-11-25  4:00           ` Michael S. Tsirkin
2016-11-25 12:31             ` Laszlo Ersek
2016-11-25 12:40               ` Laszlo Ersek
2016-11-28  9:01                 ` Gerd Hoffmann [this message]
2016-11-28 10:22                   ` Laszlo Ersek
2016-11-28 11:53                     ` Paolo Bonzini
2016-11-25 14:22               ` Igor Mammedov
2016-11-24 14:55     ` Igor Mammedov
2016-11-24 17:05       ` Paolo Bonzini
2016-11-24 18:02         ` Igor Mammedov
2016-11-25  8:55           ` Paolo Bonzini
2016-11-25 14:10             ` Igor Mammedov
2016-11-28  9:41               ` Paolo Bonzini
2016-11-28 11:24                 ` Igor Mammedov
2016-11-28 11:51                   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480323717.20061.27.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jordan.l.justen@intel.com \
    --cc=kevin@koconnor.net \
    --cc=lersek@redhat.com \
    --cc=michael.d.kinney@intel.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).