qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Adrian Bunk <bunk@stusta.de>, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 6/6] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default
Date: Mon, 28 Nov 2016 23:40:37 +0100	[thread overview]
Message-ID: <1480372837-109736-7-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1480372837-109736-1-git-send-email-pbonzini@redhat.com>

From: Adrian Bunk <bunk@stusta.de>

Building qemu fails in distributions where gcc enables PIE by default
(e.g. Debian unstable) with:

/usr/bin/ld: -r and -pie may not be used together

Use -r instead of -Wl,-r to avoid gcc passing -pie to the linker
when PIE is enabled and a relocatable object is passed.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Message-Id: <20161127162817.15144-1-bunk@stusta.de>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 rules.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules.mak b/rules.mak
index 0333ae3..545ebd9 100644
--- a/rules.mak
+++ b/rules.mak
@@ -93,7 +93,7 @@ module-common.o: CFLAGS += $(DSO_OBJ_CFLAGS)
 	$(if $(findstring /,$@),$(call quiet-command,cp $@ $(subst /,-,$@),"CP","$(subst /,-,$@)"))
 
 
-LD_REL := $(CC) -nostdlib -Wl,-r $(LD_REL_FLAGS)
+LD_REL := $(CC) -nostdlib -r $(LD_REL_FLAGS)
 
 %.mo:
 	$(call quiet-command,$(LD_REL) -o $@ $^,"LD","$(TARGET_DIR)$@")
-- 
1.8.3.1

  parent reply	other threads:[~2016-11-28 22:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 22:40 [Qemu-devel] [PULL 0/6] More patches for QEMU 2.8-rc2 Paolo Bonzini
2016-11-28 22:40 ` [Qemu-devel] [PULL 1/6] megasas: do not call pci_dma_unmap after having freed the frame once Paolo Bonzini
2016-11-28 22:40 ` [Qemu-devel] [PULL 2/6] megasas: clean up and fix request completion/cancellation Paolo Bonzini
2016-11-28 22:40 ` [Qemu-devel] [PULL 3/6] pci-assign: sync MSI/MSI-X cap and table with PCIDevice Paolo Bonzini
2016-11-28 22:40 ` [Qemu-devel] [PULL 4/6] migration/pcspk: Add a property to state if pcspk is migrated Paolo Bonzini
2016-11-28 22:40 ` [Qemu-devel] [PULL 5/6] migration/pcspk: Turn migration of pcspk off for 2.7 and older Paolo Bonzini
2016-11-28 22:40 ` Paolo Bonzini [this message]
2016-11-29  9:56 ` [Qemu-devel] [PULL 0/6] More patches for QEMU 2.8-rc2 Stefan Hajnoczi
2016-11-29 10:05 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480372837-109736-7-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bunk@stusta.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).