Re: [Qemu-devel] [PATCH for-2.8 0/2] loader fixes

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH for-2.8 0/2] loader fixes
Type: series
Message-id: 20161128195701.24912-1-lersek@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a700709 loader: fix undefined behavior in rom_order_compare()
54ae01b loader: fix handling of custom address spaces when adding ROM blobs

=== OUTPUT BEGIN ===
Checking PATCH 1/2: loader: fix handling of custom address spaces when adding ROM blobs...
Checking PATCH 2/2: loader: fix undefined behavior in rom_order_compare()...
ERROR: "(foo*)" should be "(foo *)"
#69: FILE: hw/core/loader.c:821:
+    return ((uintptr_t)(void*)rom->as > (uintptr_t)(void*)item->as) ||

total: 1 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org