From: Gerd Hoffmann <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu devel list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] a suggestion to place *.c hunks last in patches
Date: Wed, 30 Nov 2016 13:29:16 +0100 [thread overview]
Message-ID: <1480508956.20354.28.camel@redhat.com> (raw)
In-Reply-To: <0a6692f7-d2d3-2902-d5f0-77035c90a6cb@redhat.com>
Hi,
> > Want sent a patch?
>
> What file for? :)
create something like scripts/git.orderfile, so people have just to run
"git config diff.orderfile scripts/git.orderfile" to enable it, and we
can refine the config without having everybody update the orderfile
manually?
> I've considered modifying
> <http://wiki.qemu.org/Contribute/SubmitAPatch>, but that article is
> humongous already.
>
> Nonetheless, section "Make code motion patches easy to review" mentions
> some diff.* settings, so I guess a new section after it ("Format
> declarative and abstract changes near the top") would be appropriate, if
> there's no disagreement.
Yep, adding to the wiki sounds good too.
> > Can this be automatically enabled per repo, like .gitignore, so it works
> > without everybody tweaking its local git config?
>
> Not to my understanding.
Too bad.
cheers,
Gerd
next prev parent reply other threads:[~2016-11-30 12:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 10:08 [Qemu-devel] a suggestion to place *.c hunks last in patches Laszlo Ersek
2016-11-30 10:55 ` Gerd Hoffmann
2016-11-30 12:03 ` Laszlo Ersek
2016-11-30 12:27 ` Fam Zheng
2016-12-02 10:15 ` Laszlo Ersek
2016-11-30 12:29 ` Gerd Hoffmann [this message]
2016-11-30 15:36 ` Laszlo Ersek
2016-11-30 20:48 ` John Snow
2016-11-30 21:54 ` Laszlo Ersek
2016-12-02 10:23 ` Stefan Hajnoczi
2016-11-30 15:08 ` Michael S. Tsirkin
2016-11-30 15:26 ` Laszlo Ersek
2016-11-30 18:31 ` Michael S. Tsirkin
2016-11-30 15:35 ` Stefan Hajnoczi
2016-11-30 15:41 ` Eric Blake
2016-11-30 20:02 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480508956.20354.28.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).