From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL 2/5] intel_iommu: fix incorrect device invalidate
Date: Thu, 1 Dec 2016 05:58:45 +0200 [thread overview]
Message-ID: <1480564455-23933-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1480564455-23933-1-git-send-email-mst@redhat.com>
From: Peter Xu <peterx@redhat.com>
"mask" needs to be inverted before use.
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/intel_iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 1b706ad..5f3e351 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -988,6 +988,7 @@ static void vtd_context_device_invalidate(IntelIOMMUState *s,
mask = 7; /* Mask bit 2:0 in the SID field */
break;
}
+ mask = ~mask;
VTD_DPRINTF(INV, "device-selective invalidation source 0x%"PRIx16
" mask %"PRIu16, source_id, mask);
vtd_bus = vtd_find_as_from_bus_num(s, VTD_SID_TO_BUS(source_id));
--
MST
next prev parent reply other threads:[~2016-12-01 3:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 3:58 [Qemu-devel] [PULL 0/5] virtio, vhost, pc: fixes Michael S. Tsirkin
2016-12-01 3:58 ` [Qemu-devel] [PULL 1/5] spec/vhost-user: fix the VHOST_USER prefix Michael S. Tsirkin
2016-12-01 3:58 ` Michael S. Tsirkin [this message]
2016-12-01 3:58 ` [Qemu-devel] [PULL 3/5] loader: fix handling of custom address spaces when adding ROM blobs Michael S. Tsirkin
2016-12-01 3:58 ` [Qemu-devel] [PULL 4/5] loader: fix undefined behavior in rom_order_compare() Michael S. Tsirkin
2016-12-01 3:58 ` [Qemu-devel] [PULL 5/5] virtio-crypto: fix uninitialized variables Michael S. Tsirkin
2016-12-01 13:39 ` [Qemu-devel] [PULL 0/5] virtio, vhost, pc: fixes Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480564455-23933-3-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).