* [Qemu-devel] [PATCH] docs: Fix description of the sentence
@ 2016-12-01 6:55 Zhang Chen
2016-12-01 14:57 ` [Qemu-devel] [PATCH for-2.8] " Eric Blake
0 siblings, 1 reply; 12+ messages in thread
From: Zhang Chen @ 2016-12-01 6:55 UTC (permalink / raw)
To: qemu devel, QEMU Trivial, Michael Tokarev, Laurent Vivier
Cc: Zhang Chen, Eric Blake, Stefan Weil
Say it in another way to make it easier to understand.
Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
docs/colo-proxy.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt
index 76767cb..c4941de 100644
--- a/docs/colo-proxy.txt
+++ b/docs/colo-proxy.txt
@@ -158,7 +158,9 @@ secondary.
== Usage ==
-Here, we use demo ip and port discribe more clearly.
+Here is an example using demonstration IP and port addresses to more
+clearly describe the usage.
+
Primary(ip:3.3.3.3):
-netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
-device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence
2016-12-01 6:55 [Qemu-devel] [PATCH] docs: Fix description of the sentence Zhang Chen
@ 2016-12-01 14:57 ` Eric Blake
2016-12-02 2:59 ` Zhang Chen
0 siblings, 1 reply; 12+ messages in thread
From: Eric Blake @ 2016-12-01 14:57 UTC (permalink / raw)
To: Zhang Chen, qemu devel, QEMU Trivial, Michael Tokarev,
Laurent Vivier
Cc: Stefan Weil
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
On 12/01/2016 12:55 AM, Zhang Chen wrote:
> Say it in another way to make it easier to understand.
>
> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
I guess that's because I suggested the replacement text to use, even
though I didn't write the patch.
At any rate, since this is doc-only, it's safe for inclusion in 2.8, if
the maintainer wants to send a last-minute pull request (but if it
misses the release, that's okay too)
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> docs/colo-proxy.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt
> index 76767cb..c4941de 100644
> --- a/docs/colo-proxy.txt
> +++ b/docs/colo-proxy.txt
> @@ -158,7 +158,9 @@ secondary.
>
> == Usage ==
>
> -Here, we use demo ip and port discribe more clearly.
> +Here is an example using demonstration IP and port addresses to more
> +clearly describe the usage.
> +
> Primary(ip:3.3.3.3):
> -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
> -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence
2016-12-01 14:57 ` [Qemu-devel] [PATCH for-2.8] " Eric Blake
@ 2016-12-02 2:59 ` Zhang Chen
2016-12-02 3:14 ` Eric Blake
2016-12-02 7:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
0 siblings, 2 replies; 12+ messages in thread
From: Zhang Chen @ 2016-12-02 2:59 UTC (permalink / raw)
To: Eric Blake, qemu devel, QEMU Trivial, Michael Tokarev,
Laurent Vivier
Cc: Stefan Weil
On 12/01/2016 10:57 PM, Eric Blake wrote:
> On 12/01/2016 12:55 AM, Zhang Chen wrote:
>> Say it in another way to make it easier to understand.
>>
>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
> I guess that's because I suggested the replacement text to use, even
> though I didn't write the patch.
Yes, In that case, should I change the signed-off-by to acked-by or
remove it?
Thanks
Zhang Chen
> At any rate, since this is doc-only, it's safe for inclusion in 2.8, if
> the maintainer wants to send a last-minute pull request (but if it
> misses the release, that's okay too)
>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> docs/colo-proxy.txt | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt
>> index 76767cb..c4941de 100644
>> --- a/docs/colo-proxy.txt
>> +++ b/docs/colo-proxy.txt
>> @@ -158,7 +158,9 @@ secondary.
>>
>> == Usage ==
>>
>> -Here, we use demo ip and port discribe more clearly.
>> +Here is an example using demonstration IP and port addresses to more
>> +clearly describe the usage.
>> +
>> Primary(ip:3.3.3.3):
>> -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
>> -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66
>>
--
Thanks
zhangchen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence
2016-12-02 2:59 ` Zhang Chen
@ 2016-12-02 3:14 ` Eric Blake
2016-12-02 7:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
1 sibling, 0 replies; 12+ messages in thread
From: Eric Blake @ 2016-12-02 3:14 UTC (permalink / raw)
To: Zhang Chen, qemu devel, QEMU Trivial, Michael Tokarev,
Laurent Vivier
Cc: Stefan Weil
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
On 12/01/2016 08:59 PM, Zhang Chen wrote:
>
>
> On 12/01/2016 10:57 PM, Eric Blake wrote:
>> On 12/01/2016 12:55 AM, Zhang Chen wrote:
>>> Say it in another way to make it easier to understand.
>>>
>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> I guess that's because I suggested the replacement text to use, even
>> though I didn't write the patch.
>
> Yes, In that case, should I change the signed-off-by to acked-by or
> remove it?
I'm okay if you want to leave it as-is.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.8] docs: Fix description of the sentence
2016-12-02 2:59 ` Zhang Chen
2016-12-02 3:14 ` Eric Blake
@ 2016-12-02 7:57 ` Laurent Vivier
2016-12-07 8:58 ` Zhang Chen
1 sibling, 1 reply; 12+ messages in thread
From: Laurent Vivier @ 2016-12-02 7:57 UTC (permalink / raw)
To: Zhang Chen, Eric Blake, qemu devel, QEMU Trivial, Michael Tokarev,
Laurent Vivier
Cc: Stefan Weil
On 02/12/2016 03:59, Zhang Chen wrote:
>
>
> On 12/01/2016 10:57 PM, Eric Blake wrote:
>> On 12/01/2016 12:55 AM, Zhang Chen wrote:
>>> Say it in another way to make it easier to understand.
>>>
>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> I guess that's because I suggested the replacement text to use, even
>> though I didn't write the patch.
>
> Yes, In that case, should I change the signed-off-by to acked-by or
> remove it?
You can use "Suggested-by:"
https://www.kernel.org/doc/Documentation/SubmittingPatches
Laurent
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.8] docs: Fix description of the sentence
2016-12-02 7:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2016-12-07 8:58 ` Zhang Chen
2016-12-07 9:01 ` Laurent Vivier
0 siblings, 1 reply; 12+ messages in thread
From: Zhang Chen @ 2016-12-07 8:58 UTC (permalink / raw)
To: Laurent Vivier, Eric Blake, qemu devel, QEMU Trivial,
Michael Tokarev, Laurent Vivier
Cc: Stefan Weil
On 12/02/2016 03:57 PM, Laurent Vivier wrote:
>
> On 02/12/2016 03:59, Zhang Chen wrote:
>>
>> On 12/01/2016 10:57 PM, Eric Blake wrote:
>>> On 12/01/2016 12:55 AM, Zhang Chen wrote:
>>>> Say it in another way to make it easier to understand.
>>>>
>>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>> I guess that's because I suggested the replacement text to use, even
>>> though I didn't write the patch.
>> Yes, In that case, should I change the signed-off-by to acked-by or
>> remove it?
> You can use "Suggested-by:"
>
> https://www.kernel.org/doc/Documentation/SubmittingPatches
>
> Laurent
>
Should I fix it? or can you pick up this directly for 2.8?
Thanks
Zhang Chen
>
--
Thanks
zhangchen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.8] docs: Fix description of the sentence
2016-12-07 8:58 ` Zhang Chen
@ 2016-12-07 9:01 ` Laurent Vivier
2016-12-07 13:30 ` Stefan Hajnoczi
0 siblings, 1 reply; 12+ messages in thread
From: Laurent Vivier @ 2016-12-07 9:01 UTC (permalink / raw)
To: Zhang Chen, Laurent Vivier, Eric Blake, qemu devel, QEMU Trivial,
Michael Tokarev
Cc: Stefan Weil, Stefan Hajnoczi
Le 07/12/2016 à 09:58, Zhang Chen a écrit :
>
>
> On 12/02/2016 03:57 PM, Laurent Vivier wrote:
>>
>> On 02/12/2016 03:59, Zhang Chen wrote:
>>>
>>> On 12/01/2016 10:57 PM, Eric Blake wrote:
>>>> On 12/01/2016 12:55 AM, Zhang Chen wrote:
>>>>> Say it in another way to make it easier to understand.
>>>>>
>>>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>>> I guess that's because I suggested the replacement text to use, even
>>>> though I didn't write the patch.
>>> Yes, In that case, should I change the signed-off-by to acked-by or
>>> remove it?
>> You can use "Suggested-by:"
>>
>> https://www.kernel.org/doc/Documentation/SubmittingPatches
>>
>> Laurent
>>
>
> Should I fix it? or can you pick up this directly for 2.8?
I don't think it is needed.
Perhaps Stefan H can take it directly in his staging tree?
Thanks,
Laurent
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.8] docs: Fix description of the sentence
2016-12-07 9:01 ` Laurent Vivier
@ 2016-12-07 13:30 ` Stefan Hajnoczi
2016-12-08 1:32 ` [Qemu-devel] [Qemu-trivial] [PATCH for-2.9] " Zhang Chen
0 siblings, 1 reply; 12+ messages in thread
From: Stefan Hajnoczi @ 2016-12-07 13:30 UTC (permalink / raw)
To: Laurent Vivier
Cc: Zhang Chen, Laurent Vivier, Eric Blake, qemu devel, QEMU Trivial,
Michael Tokarev, Stefan Weil
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
On Wed, Dec 07, 2016 at 10:01:49AM +0100, Laurent Vivier wrote:
> Le 07/12/2016 à 09:58, Zhang Chen a écrit :
> >
> >
> > On 12/02/2016 03:57 PM, Laurent Vivier wrote:
> >>
> >> On 02/12/2016 03:59, Zhang Chen wrote:
> >>>
> >>> On 12/01/2016 10:57 PM, Eric Blake wrote:
> >>>> On 12/01/2016 12:55 AM, Zhang Chen wrote:
> >>>>> Say it in another way to make it easier to understand.
> >>>>>
> >>>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> >>>>> Signed-off-by: Eric Blake <eblake@redhat.com>
> >>>> I guess that's because I suggested the replacement text to use, even
> >>>> though I didn't write the patch.
> >>> Yes, In that case, should I change the signed-off-by to acked-by or
> >>> remove it?
> >> You can use "Suggested-by:"
> >>
> >> https://www.kernel.org/doc/Documentation/SubmittingPatches
> >>
> >> Laurent
> >>
> >
> > Should I fix it? or can you pick up this directly for 2.8?
>
> I don't think it is needed.
> Perhaps Stefan H can take it directly in his staging tree?
Too late for that now. This should be merged through Jason Wang (net
maintainer) like any other colo-proxy patch.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.9] docs: Fix description of the sentence
2016-12-07 13:30 ` Stefan Hajnoczi
@ 2016-12-08 1:32 ` Zhang Chen
2016-12-26 7:26 ` Zhang Chen
0 siblings, 1 reply; 12+ messages in thread
From: Zhang Chen @ 2016-12-08 1:32 UTC (permalink / raw)
To: Stefan Hajnoczi, Laurent Vivier
Cc: Laurent Vivier, Eric Blake, qemu devel, QEMU Trivial, Jason Wang,
Stefan Weil
On 12/07/2016 09:30 PM, Stefan Hajnoczi wrote:
> On Wed, Dec 07, 2016 at 10:01:49AM +0100, Laurent Vivier wrote:
>> Le 07/12/2016 à 09:58, Zhang Chen a écrit :
>>>
>>> On 12/02/2016 03:57 PM, Laurent Vivier wrote:
>>>> On 02/12/2016 03:59, Zhang Chen wrote:
>>>>> On 12/01/2016 10:57 PM, Eric Blake wrote:
>>>>>> On 12/01/2016 12:55 AM, Zhang Chen wrote:
>>>>>>> Say it in another way to make it easier to understand.
>>>>>>>
>>>>>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>>>>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>>>>> I guess that's because I suggested the replacement text to use, even
>>>>>> though I didn't write the patch.
>>>>> Yes, In that case, should I change the signed-off-by to acked-by or
>>>>> remove it?
>>>> You can use "Suggested-by:"
>>>>
>>>> https://www.kernel.org/doc/Documentation/SubmittingPatches
>>>>
>>>> Laurent
>>>>
>>> Should I fix it? or can you pick up this directly for 2.8?
>> I don't think it is needed.
>> Perhaps Stefan H can take it directly in his staging tree?
> Too late for that now. This should be merged through Jason Wang (net
> maintainer) like any other colo-proxy patch.
>
OK~ I change the subject to "for-2.9" and cc Jason.
Thanks
Zhang Chen
--
Thanks
zhangchen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.9] docs: Fix description of the sentence
2016-12-08 1:32 ` [Qemu-devel] [Qemu-trivial] [PATCH for-2.9] " Zhang Chen
@ 2016-12-26 7:26 ` Zhang Chen
2017-01-06 3:33 ` Zhang Chen
0 siblings, 1 reply; 12+ messages in thread
From: Zhang Chen @ 2016-12-26 7:26 UTC (permalink / raw)
To: Jason Wang
Cc: Stefan Hajnoczi, Laurent Vivier, Laurent Vivier, QEMU Trivial,
Stefan Weil, qemu devel
Hi~~ Jason.
Can you pick up this patch?
Thanks
Zhang Chen
On 12/08/2016 09:32 AM, Zhang Chen wrote:
>
>
> On 12/07/2016 09:30 PM, Stefan Hajnoczi wrote:
>> On Wed, Dec 07, 2016 at 10:01:49AM +0100, Laurent Vivier wrote:
>>> Le 07/12/2016 à 09:58, Zhang Chen a écrit :
>>>>
>>>> On 12/02/2016 03:57 PM, Laurent Vivier wrote:
>>>>> On 02/12/2016 03:59, Zhang Chen wrote:
>>>>>> On 12/01/2016 10:57 PM, Eric Blake wrote:
>>>>>>> On 12/01/2016 12:55 AM, Zhang Chen wrote:
>>>>>>>> Say it in another way to make it easier to understand.
>>>>>>>>
>>>>>>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>>>>>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>>>>>> I guess that's because I suggested the replacement text to use,
>>>>>>> even
>>>>>>> though I didn't write the patch.
>>>>>> Yes, In that case, should I change the signed-off-by to acked-by or
>>>>>> remove it?
>>>>> You can use "Suggested-by:"
>>>>>
>>>>> https://www.kernel.org/doc/Documentation/SubmittingPatches
>>>>>
>>>>> Laurent
>>>>>
>>>> Should I fix it? or can you pick up this directly for 2.8?
>>> I don't think it is needed.
>>> Perhaps Stefan H can take it directly in his staging tree?
>> Too late for that now. This should be merged through Jason Wang (net
>> maintainer) like any other colo-proxy patch.
>>
>
> OK~ I change the subject to "for-2.9" and cc Jason.
>
> Thanks
> Zhang Chen
>
>
--
Thanks
Zhang Chen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.9] docs: Fix description of the sentence
2016-12-26 7:26 ` Zhang Chen
@ 2017-01-06 3:33 ` Zhang Chen
2017-01-06 3:47 ` Jason Wang
0 siblings, 1 reply; 12+ messages in thread
From: Zhang Chen @ 2017-01-06 3:33 UTC (permalink / raw)
To: Jason Wang
Cc: Laurent Vivier, QEMU Trivial, Stefan Hajnoczi, qemu devel,
Laurent Vivier, Stefan Weil
Ping....
On 12/26/2016 03:26 PM, Zhang Chen wrote:
> Hi~~ Jason.
>
> Can you pick up this patch?
>
> Thanks
>
> Zhang Chen
>
>
> On 12/08/2016 09:32 AM, Zhang Chen wrote:
>>
>>
>> On 12/07/2016 09:30 PM, Stefan Hajnoczi wrote:
>>> On Wed, Dec 07, 2016 at 10:01:49AM +0100, Laurent Vivier wrote:
>>>> Le 07/12/2016 à 09:58, Zhang Chen a écrit :
>>>>>
>>>>> On 12/02/2016 03:57 PM, Laurent Vivier wrote:
>>>>>> On 02/12/2016 03:59, Zhang Chen wrote:
>>>>>>> On 12/01/2016 10:57 PM, Eric Blake wrote:
>>>>>>>> On 12/01/2016 12:55 AM, Zhang Chen wrote:
>>>>>>>>> Say it in another way to make it easier to understand.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>>>>>>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>>>>>>> I guess that's because I suggested the replacement text to use,
>>>>>>>> even
>>>>>>>> though I didn't write the patch.
>>>>>>> Yes, In that case, should I change the signed-off-by to acked-by or
>>>>>>> remove it?
>>>>>> You can use "Suggested-by:"
>>>>>>
>>>>>> https://www.kernel.org/doc/Documentation/SubmittingPatches
>>>>>>
>>>>>> Laurent
>>>>>>
>>>>> Should I fix it? or can you pick up this directly for 2.8?
>>>> I don't think it is needed.
>>>> Perhaps Stefan H can take it directly in his staging tree?
>>> Too late for that now. This should be merged through Jason Wang (net
>>> maintainer) like any other colo-proxy patch.
>>>
>>
>> OK~ I change the subject to "for-2.9" and cc Jason.
>>
>> Thanks
>> Zhang Chen
>>
>>
>
--
Thanks
Zhang Chen
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-01-06 3:47 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-01 6:55 [Qemu-devel] [PATCH] docs: Fix description of the sentence Zhang Chen
2016-12-01 14:57 ` [Qemu-devel] [PATCH for-2.8] " Eric Blake
2016-12-02 2:59 ` Zhang Chen
2016-12-02 3:14 ` Eric Blake
2016-12-02 7:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2016-12-07 8:58 ` Zhang Chen
2016-12-07 9:01 ` Laurent Vivier
2016-12-07 13:30 ` Stefan Hajnoczi
2016-12-08 1:32 ` [Qemu-devel] [Qemu-trivial] [PATCH for-2.9] " Zhang Chen
2016-12-26 7:26 ` Zhang Chen
2017-01-06 3:33 ` Zhang Chen
2017-01-06 3:47 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).