From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCm0q-0003eV-7b for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:28:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCm0m-0001oG-8x for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:28:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58692) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cCm0m-0001o5-2o for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:28:16 -0500 From: P J P Date: Fri, 2 Dec 2016 16:58:08 +0530 Message-Id: <1480678088-21464-1-git-send-email-ppandit@redhat.com> Subject: [Qemu-devel] [PATCH] net: virtio-net: initialise local 'netcfg' variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Developers Cc: Jason Wang , Azureyang , Prasad J Pandit From: Prasad J Pandit Local 'netcfg' variable in 'virtio_net_get_config' routine was not initialised. It could leak uninitialised 'netcfg.mtu' field memory. Initialise 'netcfg' to avoid it. Reported-by: Azureyang Signed-off-by: Prasad J Pandit --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 01f1351..cb5b3dc 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -72,7 +72,7 @@ static int vq2q(int queue_index) static void virtio_net_get_config(VirtIODevice *vdev, uint8_t *config) { VirtIONet *n = VIRTIO_NET(vdev); - struct virtio_net_config netcfg; + struct virtio_net_config netcfg = {}; virtio_stw_p(vdev, &netcfg.status, n->status); virtio_stw_p(vdev, &netcfg.max_virtqueue_pairs, n->max_queues); -- 2.7.4