From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDM76-0004oE-Mm for qemu-devel@nongnu.org; Sat, 03 Dec 2016 21:01:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDM75-0004ip-OF for qemu-devel@nongnu.org; Sat, 03 Dec 2016 21:01:12 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:46542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDM75-0004hU-IG for qemu-devel@nongnu.org; Sat, 03 Dec 2016 21:01:11 -0500 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id 543FE7FD0EC3F for ; Sun, 4 Dec 2016 02:01:01 +0000 (GMT) From: Yongbok Kim Date: Sun, 4 Dec 2016 02:00:17 +0000 Message-ID: <1480816817-53245-5-git-send-email-yongbok.kim@imgtec.com> In-Reply-To: <1480816817-53245-1-git-send-email-yongbok.kim@imgtec.com> References: <1480816817-53245-1-git-send-email-yongbok.kim@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PULL 4/4] target-mips: fix bad shifts in {dextp|dextpdp} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Fixed issues in the MIPSDSP64 instructions dextp and dextpdp. Shifting can go out of 32 bit range. https://bugs.launchpad.net/qemu/+bug/1631625 Reported-by: Thomas Huth Reported-by: Jia Liu Signed-off-by: Yongbok Kim Reviewed-by: Thomas Huth --- target-mips/dsp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index df7d220..dc70793 100644 --- a/target-mips/dsp_helper.c +++ b/target-mips/dsp_helper.c @@ -3477,7 +3477,7 @@ target_ulong helper_dextp(target_ulong ac, target_ulong size, CPUMIPSState *env) if (sub >= -1) { temp = (tempB << (64 - len)) | (tempA >> len); - temp = temp & ((0x01 << (size + 1)) - 1); + temp = temp & ((1ULL << (size + 1)) - 1); set_DSPControl_efi(0, env); } else { set_DSPControl_efi(1, env); @@ -3506,7 +3506,7 @@ target_ulong helper_dextpdp(target_ulong ac, target_ulong size, if (sub >= -1) { temp = (tempB << (64 - len)) | (tempA >> len); - temp = temp & ((0x01 << (size + 1)) - 1); + temp = temp & ((1ULL << (size + 1)) - 1); set_DSPControl_pos(sub, env); set_DSPControl_efi(0, env); } else { -- 2.7.4