From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, stefanha@redhat.com, qemu-devel@nongnu.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL V2 3/3] fsl_etsec: Fix various small problems in hexdump code
Date: Tue, 6 Dec 2016 10:32:32 +0800 [thread overview]
Message-ID: <1480991552-14360-4-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1480991552-14360-1-git-send-email-jasowang@redhat.com>
From: Andrey Smirnov <andrew.smirnov@gmail.com>
Fix various small problems in hexdump code, such as:
- Reference to non-existing field etsec->nic->nc.name is replaced
with nc->name
- Type mismatch warnings
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/fsl_etsec/etsec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index 951c5f0..fadf9c8 100644
--- a/hw/net/fsl_etsec/etsec.c
+++ b/hw/net/fsl_etsec/etsec.c
@@ -348,8 +348,8 @@ static ssize_t etsec_receive(NetClientState *nc,
eTSEC *etsec = qemu_get_nic_opaque(nc);
#if defined(HEX_DUMP)
- fprintf(stderr, "%s receive size:%d\n", etsec->nic->nc.name, size);
- qemu_hexdump(buf, stderr, "", size);
+ fprintf(stderr, "%s receive size:%zd\n", nc->name, size);
+ qemu_hexdump((void *)buf, stderr, "", size);
#endif
/* Flush is unnecessary as are already in receiving path */
etsec->need_flush = false;
--
2.7.4
next prev parent reply other threads:[~2016-12-06 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 2:32 [Qemu-devel] [PULL V2 0/3] Net patches Jason Wang
2016-12-06 2:32 ` [Qemu-devel] [PULL V2 1/3] net: mcf: check receive buffer size register value Jason Wang
2016-12-06 2:32 ` [Qemu-devel] [PULL V2 2/3] fsl_etsec: Pad short payloads with zeros Jason Wang
2016-12-06 2:32 ` Jason Wang [this message]
2016-12-06 10:24 ` [Qemu-devel] [PULL V2 0/3] Net patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480991552-14360-4-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=andrew.smirnov@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).