From: Gonglei <arei.gonglei@huawei.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, Gonglei <arei.gonglei@huawei.com>
Subject: [Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key material before free
Date: Tue, 6 Dec 2016 17:29:13 +0800 [thread overview]
Message-ID: <1481016553-69252-1-git-send-email-arei.gonglei@huawei.com> (raw)
Zeroize the memory of CryptoDevBackendSymOpInfo structure pointed
for key material security.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
hw/virtio/virtio-crypto.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c
index 2f2467e..ecb19b6 100644
--- a/hw/virtio/virtio-crypto.c
+++ b/hw/virtio/virtio-crypto.c
@@ -337,7 +337,18 @@ static void virtio_crypto_free_request(VirtIOCryptoReq *req)
{
if (req) {
if (req->flags == CRYPTODEV_BACKEND_ALG_SYM) {
- g_free(req->u.sym_op_info);
+ size_t max_len;
+ CryptoDevBackendSymOpInfo *op_info = req->u.sym_op_info;
+
+ max_len = op_info->iv_len +
+ op_info->aad_len +
+ op_info->src_len +
+ op_info->dst_len +
+ op_info->digest_result_len;
+
+ /* Zeroize and free request data structure */
+ memset(op_info, 0, sizeof(*op_info) + max_len);
+ g_free(op_info);
}
g_free(req);
}
--
1.8.3.1
next reply other threads:[~2016-12-06 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 9:29 Gonglei [this message]
2016-12-06 13:40 ` [Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key material before free Michael S. Tsirkin
2016-12-06 17:33 ` Stefan Hajnoczi
2016-12-06 19:22 ` Michael S. Tsirkin
2016-12-06 19:30 ` Eric Blake
2016-12-06 20:18 ` Stefan Hajnoczi
2016-12-07 0:57 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481016553-69252-1-git-send-email-arei.gonglei@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).