From: "Longpeng(Mike)" <longpeng2@huawei.com>
To: arei.gonglei@huawei.com, berrange@redhat.com
Cc: eblake@redhat.com, wu.wubin@huawei.com, jianjay.zhou@huawei.com,
qemu-devel@nongnu.org, "Longpeng(Mike)" <longpeng2@huawei.com>
Subject: [Qemu-devel] [PATCH for-2.9] cryptodev: remove single-DES support in cryptodev
Date: Wed, 7 Dec 2016 09:31:25 +0800 [thread overview]
Message-ID: <1481074285-178976-1-git-send-email-longpeng2@huawei.com> (raw)
Single-DES is obsolete and it's broken/useless for decades, we should
remove it in cryptodev, as suggested by Daniel.
Guest who wants to use this obsolete cipher alg will use its built-in
implementation instead.
Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
---
backends/cryptodev-builtin.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
index a4224f4..5fb2836 100644
--- a/backends/cryptodev-builtin.c
+++ b/backends/cryptodev-builtin.c
@@ -205,10 +205,6 @@ static int cryptodev_builtin_create_cipher_session(
return -1;
}
break;
- case VIRTIO_CRYPTO_CIPHER_DES_ECB:
- mode = QCRYPTO_CIPHER_MODE_ECB;
- algo = QCRYPTO_CIPHER_ALG_DES_RFB;
- break;
default:
error_setg(errp, "Unsupported cipher alg :%u",
sess_info->cipher_alg);
--
1.8.3.1
next reply other threads:[~2016-12-07 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 1:31 Longpeng(Mike) [this message]
2016-12-07 9:07 ` [Qemu-devel] [PATCH for-2.9] cryptodev: remove single-DES support in cryptodev Daniel P. Berrange
2016-12-09 5:48 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481074285-178976-1-git-send-email-longpeng2@huawei.com \
--to=longpeng2@huawei.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jianjay.zhou@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).