From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 7/8] tests: virtio-9p: no slash in path elements during walk
Date: Fri, 09 Dec 2016 10:28:28 +0100 [thread overview]
Message-ID: <148127570897.2633.4994642969353662724.stgit@bahia> (raw)
In-Reply-To: <148127558476.2633.13433882390740185948.stgit@bahia>
The walk operation is expected to fail and to return ENOENT.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
tests/virtio-9p-test.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c
index 2deb7fbf92f1..83cb23b3afc7 100644
--- a/tests/virtio-9p-test.c
+++ b/tests/virtio-9p-test.c
@@ -276,6 +276,14 @@ static void v9fs_req_free(P9Req *req)
g_free(req);
}
+/* size[4] Rlerror tag[2] ecode[4] */
+static void v9fs_rlerror(P9Req *req, uint32_t *err)
+{
+ v9fs_req_recv(req, P9_RLERROR);
+ v9fs_uint32_read(req, err);
+ v9fs_req_free(req);
+}
+
/* size[4] Tversion tag[2] msize[4] version[s] */
static P9Req *v9fs_tversion(QVirtIO9P *v9p, uint32_t msize, const char *version)
{
@@ -427,6 +435,21 @@ static void fs_walk(QVirtIO9P *v9p)
g_free(wqid);
}
+static void fs_walk_no_slash(QVirtIO9P *v9p)
+{
+ char *const wnames[] = { g_strdup(" /") };
+ P9Req *req;
+ uint32_t err;
+
+ fs_attach(v9p);
+ req = v9fs_twalk(v9p, 0, 1, 1, wnames);
+ v9fs_rlerror(req, &err);
+
+ g_assert_cmpint(err, ==, ENOENT);
+
+ g_free(wnames[0]);
+}
+
typedef void (*v9fs_test_fn)(QVirtIO9P *v9p);
static void v9fs_run_pci_test(gconstpointer data)
@@ -453,6 +476,7 @@ int main(int argc, char **argv)
v9fs_qtest_pci_add("/virtio/9p/pci/fs/version/basic", fs_version);
v9fs_qtest_pci_add("/virtio/9p/pci/fs/attach/basic", fs_attach);
v9fs_qtest_pci_add("/virtio/9p/pci/fs/walk/basic", fs_walk);
+ v9fs_qtest_pci_add("/virtio/9p/pci/fs/walk/no_slash", fs_walk_no_slash);
return g_test_run();
}
next prev parent reply other threads:[~2016-12-09 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 9:27 [Qemu-devel] [PATCH 0/8] tests: add 9P functional tests Greg Kurz
2016-12-09 9:27 ` [Qemu-devel] [PATCH 1/8] tests: virtio-9p: rename PCI configuration test Greg Kurz
2016-12-09 9:27 ` [Qemu-devel] [PATCH 2/8] tests: virtio-9p: code refactoring Greg Kurz
2016-12-09 9:28 ` [Qemu-devel] [PATCH 3/8] 9pfs: fix P9_NOTAG and P9_NOFID macros Greg Kurz
2016-12-09 21:25 ` Eric Blake
2016-12-10 13:57 ` Greg Kurz
2016-12-10 16:24 ` Eric Blake
2016-12-10 23:03 ` Greg Kurz
2016-12-09 9:28 ` [Qemu-devel] [PATCH 4/8] tests: virtio-9p: add version operation test Greg Kurz
2016-12-09 9:28 ` [Qemu-devel] [PATCH 5/8] tests: virtio-9p: add attach " Greg Kurz
2016-12-09 9:28 ` [Qemu-devel] [PATCH 6/8] tests: virtio-9p: add walk " Greg Kurz
2016-12-09 9:28 ` Greg Kurz [this message]
2016-12-09 9:28 ` [Qemu-devel] [PATCH 8/8] tests: virtio-9p: ".." cannot be used to walk out of the shared directory Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148127570897.2633.4994642969353662724.stgit@bahia \
--to=groug@kaod.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).