From: Gerd Hoffmann <kraxel@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Zhenhao Hong <zhenhaohong@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size
Date: Tue, 13 Dec 2016 13:07:52 +0100 [thread overview]
Message-ID: <1481630872.27088.128.camel@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1612131703450.6298@wniryva>
> | This is not the guest returning the size, it is the host renderer
> | library saying how much space it needs ...
>
> The library funcion checks 'capset_id' supplied via the 'cmd' object, as
> 'gc' is initialised from a given command 'cmd'. It sets 'max_size=0' if
> capset_id != VREND_CAP_SET.
Ah, ok, that makes sense.
I guess we want throw an error (VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER)
in the error case then instead of leaving resp->hdr.type unset.
cheers,
Gerd
next prev parent reply other threads:[~2016-12-13 12:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 7:14 [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size P J P
2016-12-13 10:52 ` Pankaj Gupta
2016-12-13 11:33 ` P J P
2016-12-13 11:17 ` Gerd Hoffmann
2016-12-13 11:50 ` P J P
2016-12-13 12:07 ` Gerd Hoffmann [this message]
2016-12-13 14:26 ` P J P
2016-12-13 16:01 ` Marc-André Lureau
2016-12-14 7:03 ` P J P
-- strict thread matches above, loose matches on Subject: below --
2016-12-14 7:01 P J P
2016-12-20 11:04 ` P J P
2016-12-20 14:36 ` Gerd Hoffmann
2016-12-20 11:08 ` Marc-André Lureau
2016-12-20 11:56 ` P J P
2016-12-20 13:52 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481630872.27088.128.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhenhaohong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).