From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Haozhong Zhang <haozhong.zhang@intel.com>
Subject: [Qemu-devel] [PATCH 2/4] kvm: Allow invtsc migration if tsc-khz is set explicitly
Date: Tue, 27 Dec 2016 17:21:18 -0200 [thread overview]
Message-ID: <1482866480-26208-3-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1482866480-26208-1-git-send-email-ehabkost@redhat.com>
We can safely allow a VM to be migrated with invtsc enabled if
tsc-khz is set explicitly, because QEMU already refuses to start
if it can't set the TSC frequency to the configured value.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/i386/kvm.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index a26290f..6a51399 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -962,15 +962,16 @@ int kvm_arch_init_vcpu(CPUState *cs)
has_msr_mcg_ext_ctl = has_msr_feature_control = true;
}
- if ((env->features[FEAT_8000_0007_EDX] & CPUID_APM_INVTSC) &&
- invtsc_mig_blocker == NULL) {
- /* for migration */
- error_setg(&invtsc_mig_blocker,
- "State blocked by non-migratable CPU device"
- " (invtsc flag)");
- migrate_add_blocker(invtsc_mig_blocker);
- /* for savevm */
- vmstate_x86_cpu.unmigratable = 1;
+ if (!env->user_tsc_khz) {
+ if ((env->features[FEAT_8000_0007_EDX] & CPUID_APM_INVTSC) &&
+ invtsc_mig_blocker == NULL) {
+ /* for migration */
+ error_setg(&invtsc_mig_blocker,
+ "State blocked by non-migratable CPU device"
+ " (invtsc flag)");
+ migrate_add_blocker(invtsc_mig_blocker);
+ /* for savevm */
+ vmstate_x86_cpu.unmigratable = 1;
}
cpuid_data.cpuid.padding = 0;
--
2.7.4
next prev parent reply other threads:[~2016-12-27 19:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 19:21 [Qemu-devel] [PATCH 0/4] Allow migration with invtsc if there's no frequency mismatch Eduardo Habkost
2016-12-27 19:21 ` [Qemu-devel] [PATCH 1/4] kvm: Simplify invtsc check Eduardo Habkost
2016-12-29 18:57 ` Marcelo Tosatti
2016-12-27 19:21 ` Eduardo Habkost [this message]
2017-01-04 11:44 ` [Qemu-devel] [PATCH 2/4] kvm: Allow invtsc migration if tsc-khz is set explicitly Marcelo Tosatti
2017-01-04 11:57 ` Marcelo Tosatti
2017-01-04 13:40 ` Eduardo Habkost
2017-01-04 13:45 ` Marcelo Tosatti
2017-01-04 13:51 ` Eduardo Habkost
2016-12-27 19:21 ` [Qemu-devel] [PATCH 3/4] pc: Add 2.9 machine-types Eduardo Habkost
2016-12-30 13:38 ` Igor Mammedov
2017-01-04 14:01 ` Laszlo Ersek
2017-01-04 14:20 ` Eduardo Habkost
2017-01-04 16:40 ` Laszlo Ersek
2017-01-04 17:46 ` Eduardo Habkost
2016-12-27 19:21 ` [Qemu-devel] [PATCH 4/4] kvm: Allow migration with invtsc Eduardo Habkost
2017-01-04 11:56 ` Marcelo Tosatti
2017-01-04 13:39 ` Eduardo Habkost
2017-01-04 19:59 ` [Qemu-devel] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc) Eduardo Habkost
2017-01-04 22:26 ` Marcelo Tosatti
2017-01-05 1:36 ` Eduardo Habkost
2017-01-05 10:48 ` Marcelo Tosatti
2017-01-05 10:50 ` Marcelo Tosatti
2017-01-05 12:19 ` Eduardo Habkost
2017-01-05 12:33 ` [Qemu-devel] [libvirt] " Daniel P. Berrange
2017-01-05 12:48 ` Eduardo Habkost
2017-01-05 13:00 ` Daniel P. Berrange
2017-01-05 13:11 ` Eduardo Habkost
2017-01-10 16:38 ` Paolo Bonzini
2017-01-06 10:31 ` [Qemu-devel] " Marcelo Tosatti
2017-01-08 15:49 ` [Qemu-devel] How to make dest host abort migration safely " Eduardo Habkost
2017-01-09 10:04 ` Dr. David Alan Gilbert
2017-01-08 20:28 ` [Qemu-devel] Exporting kvm_max_guest_tsc_khz to userspace " Eduardo Habkost
2017-01-09 14:58 ` Paolo Bonzini
2017-01-11 13:26 ` Eduardo Habkost
2017-01-11 14:06 ` Paolo Bonzini
2017-01-10 16:36 ` [Qemu-devel] TSC frequency configuration & invtsc migration " Paolo Bonzini
2017-01-11 11:58 ` Eduardo Habkost
2017-01-18 11:55 ` Marcelo Tosatti
2017-01-18 12:43 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482866480-26208-3-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).