From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, marcel@redhat.com, yvugenfi@redhat.com
Subject: [Qemu-devel] [PATCH 1/4] hw/pcie: fix Extended Configuration Space for devices with no Extended Capabilities
Date: Wed, 4 Jan 2017 21:57:15 +0200 [thread overview]
Message-ID: <1483559838-8797-2-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1483559838-8797-1-git-send-email-marcel@redhat.com>
Absence of any Extended Capabilities is required to be
indicated by an Extended Capability header with a Capability ID of
0000h, a Capability Version of 0h, and a Next Capability Offset of 000h.
Instead of inserting a 'NULL' capability is simpler to mark the start
of the Extended Configuration Space as read-only to achieve the same
behaviour.
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
hw/pci/pcie.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 99cfb45..62c1def 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -109,6 +109,9 @@ int pcie_cap_init(PCIDevice *dev, uint8_t offset, uint8_t type, uint8_t port)
PCI_EXP_DEVCAP2_EFF | PCI_EXP_DEVCAP2_EETLPP);
pci_set_word(dev->wmask + pos + PCI_EXP_DEVCTL2, PCI_EXP_DEVCTL2_EETLPPB);
+
+ /* read-only to behave like a 'NULL' Extended Capability Header */
+ pci_set_long(dev->wmask + PCI_CONFIG_SPACE_SIZE, 0);
return pos;
}
--
2.5.5
next prev parent reply other threads:[~2017-01-04 19:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 19:57 [Qemu-devel] [PATCH 0/4] hw/virtio: fix several PCI Express compliance issues Marcel Apfelbaum
2017-01-04 19:57 ` Marcel Apfelbaum [this message]
2017-01-10 3:13 ` [Qemu-devel] [PATCH 1/4] hw/pcie: fix Extended Configuration Space for devices with no Extended Capabilities Michael S. Tsirkin
2017-01-27 16:12 ` Marcel Apfelbaum
2017-01-04 19:57 ` [Qemu-devel] [PATCH 2/4] hw/virtio: fix error enabling flags in Device Control register Marcel Apfelbaum
2017-01-10 3:07 ` Michael S. Tsirkin
2017-01-27 16:07 ` Marcel Apfelbaum
2017-01-04 19:57 ` [Qemu-devel] [PATCH 3/4] hw/virtio: fix Link Control Register for PCI Express virtio devices Marcel Apfelbaum
2017-01-10 3:07 ` Michael S. Tsirkin
2017-01-04 19:57 ` [Qemu-devel] [PATCH 4/4] hw/virtio: fix Power Management " Marcel Apfelbaum
2017-01-10 3:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483559838-8797-2-git-send-email-marcel@redhat.com \
--to=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).