From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
To: qemu devel <qemu-devel@nongnu.org>, Eric Blake <eblake@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
Bian Naimeng <biannm@cn.fujitsu.com>,
"eddie . dong" <eddie.dong@intel.com>,
Wen Congyang <wencongyang@gmail.com>
Subject: [Qemu-devel] [PATCH V6 2/2] Add a new qmp command to do checkpoint, query xen replication status
Date: Thu, 5 Jan 2017 14:08:52 +0800 [thread overview]
Message-ID: <1483596532-14552-3-git-send-email-zhangchen.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1483596532-14552-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
We can call this qmp command to do checkpoint outside of qemu.
Xen colo will need this function.
Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Signed-off-by: Wen Congyang <wencongyang@gmail.com>
---
docs/qmp-commands.txt | 24 ++++++++++++++++++++++++
migration/colo.c | 17 +++++++++++++++++
qapi-schema.json | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 91 insertions(+)
diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt
index d182147..0ed6cf4 100644
--- a/docs/qmp-commands.txt
+++ b/docs/qmp-commands.txt
@@ -450,6 +450,30 @@ Example:
"arguments": {"enable": true, "primary": false} }
<- { "return": {} }
+query-xen-replication-status
+----------------------------
+
+Query replication status when vm is running.
+
+Arguments: None.
+
+Example:
+
+-> { "execute": "query-xen-replication-status" }
+<- { "return": { "status": "normal" } }
+
+xen-do-checkpoint
+-----------------
+
+Xen uses this command to notify replication to trigger a checkpoint.
+
+Arguments: None.
+
+Example:
+
+-> { "execute": "xen-do-checkpoint" }
+<- { "return": {} }
+
migrate
-------
diff --git a/migration/colo.c b/migration/colo.c
index 6fc2ade..2f98a33 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -127,6 +127,23 @@ void qmp_xen_set_replication(bool enable, bool primary,
}
}
+ReplicationResult *qmp_query_xen_replication_status(Error **errp)
+{
+ Error *err = NULL;
+ ReplicationResult *result = g_new0(ReplicationResult, 1);
+ replication_get_error_all(&err);
+ result->status = err ?
+ REPLICATION_STATUS_ERROR :
+ REPLICATION_STATUS_NORMAL;
+ error_free(err);
+ return result;
+}
+
+void qmp_xen_do_checkpoint(Error **errp)
+{
+ replication_do_checkpoint_all(errp);
+}
+
static void colo_send_message(QEMUFile *f, COLOMessage msg,
Error **errp)
{
diff --git a/qapi-schema.json b/qapi-schema.json
index 78802f4..f23c657 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -4695,6 +4695,56 @@
'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
##
+# @ReplicationStatus
+#
+# Describe the status of replication.
+#
+# @error: Replication has an error.
+#
+# @normal: Replication is running normally.
+#
+# Since 2.9
+##
+{ 'enum': 'ReplicationStatus',
+ 'data': [ 'error', 'normal' ] }
+
+##
+# @ReplicationResult
+#
+# The result format for 'query-xen-replication-status'.
+#
+# @status: enum of @ReplicationStatus, which shows current
+# replication error status
+#
+# Since 2.9
+##
+{ 'struct': 'ReplicationResult',
+ 'data': { 'status': 'ReplicationStatus'} }
+
+##
+# @query-xen-replication-status
+#
+# Query replication status while the vm is running.
+#
+# Returns: A @ReplicationResult objects showing the status.
+#
+# Since: 2.9
+##
+{ 'command': 'query-xen-replication-status',
+ 'returns': 'ReplicationResult' }
+
+##
+# @xen-do-checkpoint
+#
+# Xen uses this command to notify replication to do checkpoint.
+#
+# Returns: nothing.
+#
+# Since: 2.9
+##
+{ 'command': 'xen-do-checkpoint' }
+
+##
# @GICCapability:
#
# The struct describes capability for a specific GIC (Generic
--
2.7.4
next prev parent reply other threads:[~2017-01-05 6:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 6:08 [Qemu-devel] [PATCH V6 0/2] Add new qmp commands to suppurt Xen COLO Zhang Chen
2017-01-05 6:08 ` [Qemu-devel] [PATCH V6 1/2] Add a new qmp command to start/stop replication Zhang Chen
2017-01-05 6:08 ` Zhang Chen [this message]
2017-02-07 15:50 ` [Qemu-devel] [PATCH V6 2/2] Add a new qmp command to do checkpoint, query xen replication status Eric Blake
2017-02-08 2:22 ` Zhang Chen
2017-01-19 9:57 ` [Qemu-devel] [PATCH V6 0/2] Add new qmp commands to suppurt Xen COLO Zhang Chen
2017-01-26 3:04 ` Zhang Chen
2017-01-26 3:10 ` Jason Wang
2017-02-06 13:13 ` Dr. David Alan Gilbert
2017-02-07 2:01 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483596532-14552-3-git-send-email-zhangchen.fnst@cn.fujitsu.com \
--to=zhangchen.fnst@cn.fujitsu.com \
--cc=biannm@cn.fujitsu.com \
--cc=eblake@redhat.com \
--cc=eddie.dong@intel.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=wencongyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).