qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
	qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] ps2: Fix lost scancodes by recent changes
Date: Thu, 05 Jan 2017 09:12:11 +0100	[thread overview]
Message-ID: <1483603931.3966.12.camel@redhat.com> (raw)
In-Reply-To: <87y3yqil7s.fsf@mail.parknet.co.jp>

On Do, 2017-01-05 at 06:11 +0900, OGAWA Hirofumi wrote:
> Hervé Poussineau <hpoussin@reactos.org> writes:
> 
> > Le 04/01/2017 à 09:50, Gerd Hoffmann a écrit :
> >> On Mi, 2016-12-28 at 04:55 +0900, OGAWA Hirofumi wrote:
> >>> With "ps2: use QEMU qcodes instead of scancodes", key handling was
> >>> changed to qcode base. But all scancodes are not converted to new one.
> >>>
> >>> This adds some missing qcodes/scancodes what I found in using.
> >>
> >> Added to ui queue.
> >
> > Hi Gerd,
> >
> > Your pull request (patch 01/11) contains v2 of this patch (which is incomplete).
> > I've only reviewed v3, which is complete.
> 
> Yes, please use v3. Here is copy&paste, FWIW.

Please don't send new versions of patches as reply.  That confuses
various patch management tools, they are considered being part of the
discussion then.  This is how the reviewed-by tag ended up being
attributed to the wrong patch version.

Have a look at http://patchew.org/QEMU/ for example, the patches sent as
reply don't show up there, so they are not tested automatically.

thanks,
  Gerd

  reply	other threads:[~2017-01-05  8:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23 13:00 [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes OGAWA Hirofumi
2016-12-23 20:58 ` Hervé Poussineau
2016-12-23 22:49   ` OGAWA Hirofumi
2016-12-27 14:27     ` Hervé Poussineau
2016-12-27 19:49       ` OGAWA Hirofumi
2016-12-27 19:55         ` [Qemu-devel] [PATCH v3] " OGAWA Hirofumi
2016-12-27 20:11           ` Hervé Poussineau
2017-01-04  8:50           ` Gerd Hoffmann
2017-01-04 17:59             ` Hervé Poussineau
2017-01-04 21:11               ` OGAWA Hirofumi
2017-01-05  8:12                 ` Gerd Hoffmann [this message]
2017-01-05  8:45                   ` OGAWA Hirofumi
2016-12-23 21:58 ` [Qemu-devel] [PATCH] " Eric Blake
2016-12-23 23:33   ` OGAWA Hirofumi
2016-12-23 23:36     ` [Qemu-devel] [PATCH v2] " OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483603931.3966.12.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).