* [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow
@ 2017-01-06 17:45 Peter Maydell
2017-01-06 19:28 ` Michael Walle
2017-01-12 11:01 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2017-01-06 17:45 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: patches, Michael Walle
Don't truncate the multiplication and do a 64 bit one instead
because the result is stored in a 64 bit variable.
This fixes a similar coverity warning to commit 237a8650d640,
in a similar way, and is the other half of the fix for
coverity CID 1167561.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/display/milkymist-tmu2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/milkymist-tmu2.c b/hw/display/milkymist-tmu2.c
index 5c666f9..920374b 100644
--- a/hw/display/milkymist-tmu2.c
+++ b/hw/display/milkymist-tmu2.c
@@ -257,7 +257,7 @@ static void tmu2_start(MilkymistTMU2State *s)
glColor4f(m, m, m, (float)(s->regs[R_ALPHA] + 1) / 64.0f);
/* Read the QEMU dest. framebuffer into the OpenGL framebuffer */
- fb_len = 2 * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];
+ fb_len = 2ULL * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];
fb = cpu_physical_memory_map(s->regs[R_DSTFBUF], &fb_len, 0);
if (fb == NULL) {
glDeleteTextures(1, &texture);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow
2017-01-06 17:45 [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow Peter Maydell
@ 2017-01-06 19:28 ` Michael Walle
2017-01-12 11:01 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Walle @ 2017-01-06 19:28 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: patches
Am 6. Januar 2017 18:45:14 MEZ schrieb Peter Maydell <peter.maydell@linaro.org>:
>Don't truncate the multiplication and do a 64 bit one instead
>because the result is stored in a 64 bit variable.
>
>This fixes a similar coverity warning to commit 237a8650d640,
>in a similar way, and is the other half of the fix for
>coverity CID 1167561.
>
>Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Michael Walle <michael@walle.cc>
>---
> hw/display/milkymist-tmu2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/hw/display/milkymist-tmu2.c b/hw/display/milkymist-tmu2.c
>index 5c666f9..920374b 100644
>--- a/hw/display/milkymist-tmu2.c
>+++ b/hw/display/milkymist-tmu2.c
>@@ -257,7 +257,7 @@ static void tmu2_start(MilkymistTMU2State *s)
> glColor4f(m, m, m, (float)(s->regs[R_ALPHA] + 1) / 64.0f);
>
> /* Read the QEMU dest. framebuffer into the OpenGL framebuffer */
>- fb_len = 2 * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];
>+ fb_len = 2ULL * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];
> fb = cpu_physical_memory_map(s->regs[R_DSTFBUF], &fb_len, 0);
> if (fb == NULL) {
> glDeleteTextures(1, &texture);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow
2017-01-06 17:45 [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow Peter Maydell
2017-01-06 19:28 ` Michael Walle
@ 2017-01-12 11:01 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2017-01-12 11:01 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: Michael Walle, patches
06.01.2017 20:45, Peter Maydell wrote:
> Don't truncate the multiplication and do a 64 bit one instead
> because the result is stored in a 64 bit variable.
>
> This fixes a similar coverity warning to commit 237a8650d640,
> in a similar way, and is the other half of the fix for
> coverity CID 1167561.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-12 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-06 17:45 [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow Peter Maydell
2017-01-06 19:28 ` Michael Walle
2017-01-12 11:01 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).