qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, Gerd Hoffmann <kraxel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] virtio-gpu: fix issues with VM load code
Date: Mon,  9 Jan 2017 13:38:41 +0000	[thread overview]
Message-ID: <1483969123-14839-1-git-send-email-peter.maydell@linaro.org> (raw)

These patches fix a couple of issues with the VM load code
which I noticed while investigating a coverity warning.

The first patch fixes a problem with the accounting for
host pixmap memory usage -- we didn't recalculate the
current usage following a VM migration, but instead
started again at zero, which means that if you keep
bumping the VM from host to host you can sidestep the
host_maxmem limit.

The second patch fixes the coverity warning (that if we
fail in the "creating resources" loop in the load function
we will leak memory and so on). The leak isn't very
serious, because if we fail the inbound migration then
the whole QEMU process is pretty useless for anything,
but it's easy enough to fix "correctly", ie so that a
subsequent system reset will put the device back into
a sane state.

Peter Maydell (2):
  virtio-gpu: Recalculate VirtIOGPU::hostmem on VM load
  virtio-gpu: Fix memory leak in virtio_gpu_load()

 hw/display/virtio-gpu.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

-- 
2.7.4

             reply	other threads:[~2017-01-09 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 13:38 Peter Maydell [this message]
2017-01-09 13:38 ` [Qemu-devel] [PATCH 1/2] virtio-gpu: Recalculate VirtIOGPU::hostmem on VM load Peter Maydell
2017-01-09 13:38 ` [Qemu-devel] [PATCH 2/2] virtio-gpu: Fix memory leak in virtio_gpu_load() Peter Maydell
2017-01-10 11:41 ` [Qemu-devel] [PATCH 0/2] virtio-gpu: fix issues with VM load code Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483969123-14839-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).