From: Ashijeet Acharya <ashijeetacharya@gmail.com>
To: dgilbert@redhat.com
Cc: jsnow@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com,
kwolf@redhat.com, armbru@redhat.com, quintela@redhat.com,
mst@redhat.com, marcandre.lureau@redhat.com, groug@kaod.org,
aneesh.kumar@linux.vnet.ibm.com, peter.maydell@linaro.org,
qemu-devel@nongnu.org,
Ashijeet Acharya <ashijeetacharya@gmail.com>
Subject: [Qemu-devel] [PATCH v4 0/4] Introduce a new --only-migratable option
Date: Mon, 9 Jan 2017 22:32:44 +0530 [thread overview]
Message-ID: <1483981368-9965-1-git-send-email-ashijeetacharya@gmail.com> (raw)
Previously posted series patches:
http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg00320.html
http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg02391.html
http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg02062.html
This series adds a new command line option "--only-migratable" which will only
allow addition of those devices to a QEMU instance which are migratable and do
not abruptly fail QEMU after migration.
Patch 1 adds the new option "-only-migratable".
Patch 2 adds compatibility for various "device adding" options for both via
command line and hotplug methods.
Patch 3 helps to fail the migration blocker if the migration is already in
progress and thus cannot be blocked.
Note: This patch was originally written by John Snow and I have only made few
changes.
Patch 4 handles the special case of devices which become unmigratable
dynamically
by making call to "migrate_add_blocker". Here we fail the particular action of
the
device which results in an unmigratable VM.
Eg: 9pfs fails to mount the filesystem.
Note: I have not been able to test and compile the ARM drivers for KVM. They
are:
hw/intc/arm_gic_kvm.c
hw/intc/arm_gicv3_its_kvm.c
hw/intc/arm_gicv3_kvm.c
Changes in v4:
- drop diff in 9pfs for patch 4/4
- call clunk_fid() after freeing migration_blocker
- drop ret and use err directly
Changes in v3:
- set s->root_fid after migrate_add_blocker
- free migration_blocker inside v9fs_attach()
- change back ret<0 to just ret
- free local_err
Changes in v2:
- change the documentation for the new option
- add a NULL check for ObjectClass
- break patch 3 into patch 3 and 4
- use error_append_hint
- return -EACCES for only-migratable
- fix the error messages
Ashijeet Acharya (4):
migration: Add a new option to enable only-migratable
migration: Allow "device add" options to only add migratable devices
migration: disallow migrate_add_blocker during migration
migration: Fail migration blocker for --only-migratble
block/qcow.c | 9 ++++++++-
block/vdi.c | 9 ++++++++-
block/vhdx.c | 18 ++++++++++++------
block/vmdk.c | 10 +++++++++-
block/vpc.c | 13 ++++++++++---
block/vvfat.c | 22 ++++++++++++++--------
hw/9pfs/9p.c | 18 +++++++++++++-----
hw/display/virtio-gpu.c | 34 +++++++++++++++++++++-------------
hw/intc/arm_gic_kvm.c | 19 +++++++++++++------
hw/intc/arm_gicv3_its_kvm.c | 21 ++++++++++++++-------
hw/intc/arm_gicv3_kvm.c | 22 +++++++++++++++-------
hw/misc/ivshmem.c | 17 +++++++++++++----
hw/scsi/vhost-scsi.c | 27 +++++++++++++++++++++------
hw/usb/bus.c | 18 ++++++++++++++++++
hw/virtio/vhost.c | 10 +++++++++-
include/migration/migration.h | 9 ++++++++-
migration/migration.c | 42 ++++++++++++++++++++++++++++++++++++++++--
qdev-monitor.c | 9 +++++++++
qemu-options.hx | 9 +++++++++
stubs/migr-blocker.c | 3 ++-
target-i386/kvm.c | 19 ++++++++++++++++---
vl.c | 4 ++++
22 files changed, 286 insertions(+), 76 deletions(-)
--
2.6.2
next reply other threads:[~2017-01-09 17:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 17:02 Ashijeet Acharya [this message]
2017-01-09 17:02 ` [Qemu-devel] [PATCH v4 1/4] migration: Add a new option to enable only-migratable Ashijeet Acharya
2017-01-10 11:02 ` Dr. David Alan Gilbert
2017-01-09 17:02 ` [Qemu-devel] [PATCH v4 2/4] migration: Allow "device add" options to only add migratable devices Ashijeet Acharya
2017-01-10 11:23 ` Dr. David Alan Gilbert
2017-01-09 17:02 ` [Qemu-devel] [PATCH v4 3/4] migration: disallow migrate_add_blocker during migration Ashijeet Acharya
2017-01-10 8:25 ` Greg Kurz
2017-01-10 12:01 ` Dr. David Alan Gilbert
2017-01-10 18:33 ` Ashijeet Acharya
2017-01-09 17:02 ` [Qemu-devel] [PATCH v4 4/4] migration: Fail migration blocker for --only-migratble Ashijeet Acharya
2017-01-09 21:01 ` Eric Blake
2017-01-10 12:11 ` Dr. David Alan Gilbert
2017-01-10 17:15 ` Peter Maydell
2017-01-11 5:43 ` Ashijeet Acharya
2017-01-12 10:45 ` Ashijeet Acharya
2017-01-12 11:16 ` Greg Kurz
2017-01-12 11:50 ` Ashijeet Acharya
2017-01-09 17:27 ` [Qemu-devel] [PATCH v4 0/4] Introduce a new --only-migratable option no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483981368-9965-1-git-send-email-ashijeetacharya@gmail.com \
--to=ashijeetacharya@gmail.com \
--cc=amit.shah@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).