qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <pmoore@redhat.com>
To: Eduardo Otubo <eduardo.otubo@profitbricks.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
	philipp.gesang@intra2net.com
Subject: Re: [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break
Date: Fri, 07 Nov 2014 14:14:37 -0500	[thread overview]
Message-ID: <1484103.1nZBOjL2e0@sifl> (raw)
In-Reply-To: <1415351144-25383-1-git-send-email-eduardo.otubo@profitbricks.com>

On Friday, November 07, 2014 10:05:44 AM Eduardo Otubo wrote:
> Current stable version of libseccomp (2.1.1) only supports i386 and
> x86_64 archs correctly. This patch limits the usage of the syscall
> filter for those archs and updates to the correct last version of
> libseccomp.
> 
> This patch also fixes the bug:
> https://bugs.launchpad.net/qemu/+bug/1363641
> 
> Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks Eduardo, I'll let you know once I've cut a new release of libseccomp.

Acked-by: Paul Moore <pmoore@redhat.com>

> diff --git a/configure b/configure
> index 2f17bf3..47048f0 100755
> --- a/configure
> +++ b/configure
> @@ -1823,7 +1823,8 @@ fi
>  # libseccomp check
> 
>  if test "$seccomp" != "no" ; then
> -    if $pkg_config --atleast-version=2.1.0 libseccomp; then
> +    if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
> +        $pkg_config --atleast-version=2.1.1 libseccomp; then
>          libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
>          QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
>  	seccomp="yes"

-- 
paul moore
security and virtualization @ redhat

      parent reply	other threads:[~2014-11-07 19:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07  9:05 [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break Eduardo Otubo
2014-11-07 13:54 ` Peter Maydell
2014-11-07 19:14 ` Paul Moore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484103.1nZBOjL2e0@sifl \
    --to=pmoore@redhat.com \
    --cc=eduardo.otubo@profitbricks.com \
    --cc=peter.maydell@linaro.org \
    --cc=philipp.gesang@intra2net.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).