[Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break

[Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break

[Eduardo Otubo]

Current stable version of libseccomp (2.1.1) only supports i386 and
x86_64 archs correctly. This patch limits the usage of the syscall
filter for those archs and updates to the correct last version of
libseccomp.

This patch also fixes the bug:
https://bugs.launchpad.net/qemu/+bug/1363641

Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
---
 configure | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 2f17bf3..47048f0 100755
--- a/configure
+++ b/configure
@@ -1823,7 +1823,8 @@ fi
 # libseccomp check
 
 if test "$seccomp" != "no" ; then
-    if $pkg_config --atleast-version=2.1.0 libseccomp; then
+    if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
+        $pkg_config --atleast-version=2.1.1 libseccomp; then
         libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
         QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
 	seccomp="yes"
-- 
1.9.1

Re: [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break

[Peter Maydell]

On 7 November 2014 09:05, Eduardo Otubo <eduardo.otubo@profitbricks.com> wrote:
> Current stable version of libseccomp (2.1.1) only supports i386 and
> x86_64 archs correctly. This patch limits the usage of the syscall
> filter for those archs and updates to the correct last version of
> libseccomp.
>
> This patch also fixes the bug:
> https://bugs.launchpad.net/qemu/+bug/1363641
>
> Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break

[Paul Moore]

On Friday, November 07, 2014 10:05:44 AM Eduardo Otubo wrote:
> Current stable version of libseccomp (2.1.1) only supports i386 and
> x86_64 archs correctly. This patch limits the usage of the syscall
> filter for those archs and updates to the correct last version of
> libseccomp.
> 
> This patch also fixes the bug:
> https://bugs.launchpad.net/qemu/+bug/1363641
> 
> Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks Eduardo, I'll let you know once I've cut a new release of libseccomp.

Acked-by: Paul Moore <pmoore@redhat.com>

> diff --git a/configure b/configure
> index 2f17bf3..47048f0 100755
> --- a/configure
> +++ b/configure
> @@ -1823,7 +1823,8 @@ fi
>  # libseccomp check
> 
>  if test "$seccomp" != "no" ; then
> -    if $pkg_config --atleast-version=2.1.0 libseccomp; then
> +    if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
> +        $pkg_config --atleast-version=2.1.1 libseccomp; then
>          libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
>          QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
>  	seccomp="yes"

-- 
paul moore
security and virtualization @ redhat