* [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break
@ 2014-11-07 9:05 Eduardo Otubo
2014-11-07 13:54 ` Peter Maydell
2014-11-07 19:14 ` Paul Moore
0 siblings, 2 replies; 3+ messages in thread
From: Eduardo Otubo @ 2014-11-07 9:05 UTC (permalink / raw)
To: qemu-devel; +Cc: pmoore, peter.maydell, philipp.gesang, Eduardo Otubo
Current stable version of libseccomp (2.1.1) only supports i386 and
x86_64 archs correctly. This patch limits the usage of the syscall
filter for those archs and updates to the correct last version of
libseccomp.
This patch also fixes the bug:
https://bugs.launchpad.net/qemu/+bug/1363641
Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 2f17bf3..47048f0 100755
--- a/configure
+++ b/configure
@@ -1823,7 +1823,8 @@ fi
# libseccomp check
if test "$seccomp" != "no" ; then
- if $pkg_config --atleast-version=2.1.0 libseccomp; then
+ if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
+ $pkg_config --atleast-version=2.1.1 libseccomp; then
libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
seccomp="yes"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break
2014-11-07 9:05 [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break Eduardo Otubo
@ 2014-11-07 13:54 ` Peter Maydell
2014-11-07 19:14 ` Paul Moore
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2014-11-07 13:54 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: Paul Moore, QEMU Developers, Philipp Gesang
On 7 November 2014 09:05, Eduardo Otubo <eduardo.otubo@profitbricks.com> wrote:
> Current stable version of libseccomp (2.1.1) only supports i386 and
> x86_64 archs correctly. This patch limits the usage of the syscall
> filter for those archs and updates to the correct last version of
> libseccomp.
>
> This patch also fixes the bug:
> https://bugs.launchpad.net/qemu/+bug/1363641
>
> Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break
2014-11-07 9:05 [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break Eduardo Otubo
2014-11-07 13:54 ` Peter Maydell
@ 2014-11-07 19:14 ` Paul Moore
1 sibling, 0 replies; 3+ messages in thread
From: Paul Moore @ 2014-11-07 19:14 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: peter.maydell, qemu-devel, philipp.gesang
On Friday, November 07, 2014 10:05:44 AM Eduardo Otubo wrote:
> Current stable version of libseccomp (2.1.1) only supports i386 and
> x86_64 archs correctly. This patch limits the usage of the syscall
> filter for those archs and updates to the correct last version of
> libseccomp.
>
> This patch also fixes the bug:
> https://bugs.launchpad.net/qemu/+bug/1363641
>
> Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
> ---
> configure | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks Eduardo, I'll let you know once I've cut a new release of libseccomp.
Acked-by: Paul Moore <pmoore@redhat.com>
> diff --git a/configure b/configure
> index 2f17bf3..47048f0 100755
> --- a/configure
> +++ b/configure
> @@ -1823,7 +1823,8 @@ fi
> # libseccomp check
>
> if test "$seccomp" != "no" ; then
> - if $pkg_config --atleast-version=2.1.0 libseccomp; then
> + if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
> + $pkg_config --atleast-version=2.1.1 libseccomp; then
> libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
> QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
> seccomp="yes"
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-07 19:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-07 9:05 [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break Eduardo Otubo
2014-11-07 13:54 ` Peter Maydell
2014-11-07 19:14 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).