From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 19/33] scsi-block: fix direction of BYTCHK test for VERIFY commands
Date: Wed, 11 Jan 2017 20:35:13 +0100 [thread overview]
Message-ID: <1484163327-111841-20-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1484163327-111841-1-git-send-email-pbonzini@redhat.com>
The direction is wrong; scsi_block_is_passthrough returns
false for commands that *can* use sglists.
Reported-by: Zhang Qian <zhangqian@sangfor.com.cn>
Fixes: 8fdc7839e40f43a426bc7e858cf1dbfe315a3804
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/scsi-disk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index bdd1e5f..c080888 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2701,7 +2701,7 @@ static bool scsi_block_is_passthrough(SCSIDiskState *s, uint8_t *buf)
* for the number of logical blocks specified in the length
* field). For other modes, do not use scatter/gather operation.
*/
- if ((buf[1] & 6) != 2) {
+ if ((buf[1] & 6) == 2) {
return false;
}
break;
--
1.8.3.1
next prev parent reply other threads:[~2017-01-11 19:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 19:34 [Qemu-devel] [PULL 00/33] Misc patches for 2017-01-11 Paolo Bonzini
2017-01-11 19:34 ` [Qemu-devel] [PULL 01/33] bugfix: vm halt when in reset looping Paolo Bonzini
2017-01-11 19:34 ` [Qemu-devel] [PULL 02/33] megasas: fix guest-triggered memory leak Paolo Bonzini
2017-01-11 19:34 ` [Qemu-devel] [PULL 03/33] qom: Make all interface types abstract Paolo Bonzini
2017-01-11 19:34 ` [Qemu-devel] [PULL 04/33] smbios: filter based on CONFIG_SMBIOS rather than TARGET Paolo Bonzini
2017-01-11 19:34 ` [Qemu-devel] [PULL 05/33] stubs: merge all monitor stubs in one file, remove monitor_cur_is_qmp stub Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 06/33] stubs: move smbios stubs to hw/smbios Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 07/33] stubs: move acpi stubs to hw/acpi Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 08/33] stubs: remove unused stub for serial_hd Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 09/33] hw: move reset handlers from vl.c to hw/core Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 10/33] stubs: group stubs for user-mode emulation Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 11/33] stubs: group all monitor_fdset_* functions in a single file Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 12/33] stubs: move vhost stubs to stubs/vhost.o Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 13/33] event_notifier: cleanups around event_notifier_set_handler Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 14/33] build: remove --enable-colo/--disable-colo Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 15/33] stubs: remove stubs/kvm.c Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 16/33] acpi: filter based on CONFIG_ACPI_X86 rather than TARGET Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 17/33] target-i386: Correctly apply patch for syscall eflags.TF handling Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 18/33] pc: fix crash in rtc_set_memory() if initial cpu is marked as hotplugged Paolo Bonzini
2017-01-11 19:35 ` Paolo Bonzini [this message]
2017-01-11 19:35 ` [Qemu-devel] [PULL 20/33] serial: fix memory leak in serial exit Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 21/33] qemu-thread: fix qemu_thread_set_name() race in qemu_thread_create() Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 22/33] hxtool: emit Texinfo headings as @subsection Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 23/33] x86: ioapic: add traces for ioapic Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 24/33] x86: ioapic: dump version for "info ioapic" Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 25/33] x86: ioapic: fix fail migration when irqchip=split Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 26/33] exec: Add missing rcu_read_unlock Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 27/33] char: fix ctrl-a b not working Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 28/33] ramblock-notifier: new Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 29/33] kvm: move cpu synchronization code Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 30/33] target/i386: Add Intel HAX files Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 31/33] Plumb the HAXM-based hardware acceleration support Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 32/33] hax: add Darwin support Paolo Bonzini
2017-01-11 19:35 ` [Qemu-devel] [PULL 33/33] Revert "win32: don't run subprocess tests on Mingw32 platform" Paolo Bonzini
2017-01-11 20:32 ` [Qemu-devel] [PULL 00/33] Misc patches for 2017-01-11 no-reply
2017-01-13 9:41 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484163327-111841-20-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).