From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, graeme.gregory@linaro.org,
al.stone@linaro.org, leif.lindholm@linaro.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device
Date: Fri, 13 Jan 2017 17:32:18 +0000 [thread overview]
Message-ID: <1484328738-21149-1-git-send-email-ard.biesheuvel@linaro.org> (raw)
Linux for arm64 v4.10 and later will complain if the ECAM config space is
not reserved in the ACPI namespace:
acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem 0x3f000000-0x3fffffff] not reserved in ACPI namespace
The rationale is that OSes that don't consume the MCFG table should still
be able to infer that the PCI config space MMIO region is occupied.
So update the ACPI table generation routine to add this reservation.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
hw/arm/virt-acpi-build.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 085a61117378..50d52f685f68 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -310,6 +310,13 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
Aml *dev_rp0 = aml_device("%s", "RP0");
aml_append(dev_rp0, aml_name_decl("_ADR", aml_int(0)));
aml_append(dev, dev_rp0);
+
+ Aml *dev_res0 = aml_device("%s", "RES0");
+ aml_append(dev_res0, aml_name_decl("_HID", aml_string("PNP0C02")));
+ crs = aml_resource_template();
+ aml_append(crs, aml_memory32_fixed(base_ecam, size_ecam, AML_READ_WRITE));
+ aml_append(dev_res0, aml_name_decl("_CRS", crs));
+ aml_append(dev, dev_res0);
aml_append(scope, dev);
}
--
2.7.4
next reply other threads:[~2017-01-13 17:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 17:32 Ard Biesheuvel [this message]
2017-01-16 17:25 ` [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device Peter Maydell
2017-01-16 17:30 ` Ard Biesheuvel
2017-01-16 18:20 ` Peter Maydell
2017-01-16 19:31 ` Ard Biesheuvel
2017-01-16 21:13 ` Laszlo Ersek
2017-01-16 21:23 ` Ard Biesheuvel
2017-01-16 22:35 ` Laszlo Ersek
2017-01-17 7:47 ` Ard Biesheuvel
2017-01-17 8:50 ` Laszlo Ersek
2017-01-17 9:06 ` Ard Biesheuvel
2017-01-17 9:28 ` Laszlo Ersek
2017-01-17 14:46 ` Michael S. Tsirkin
2017-01-17 9:49 ` Andrew Jones
2017-01-17 10:56 ` Peter Maydell
2017-01-18 15:18 ` Igor Mammedov
2017-01-18 15:55 ` Laszlo Ersek
2017-01-18 17:02 ` Ard Biesheuvel
2017-01-18 17:26 ` Laszlo Ersek
2017-01-19 13:16 ` Peter Maydell
2017-01-18 14:49 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484328738-21149-1-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=al.stone@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).