* [Qemu-devel] [PATCH v2] arm: virt: Fix the segmentation fault when specifying an unsupported CPU
@ 2017-01-17 2:15 Shannon Zhao
2017-01-17 11:43 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Shannon Zhao @ 2017-01-17 2:15 UTC (permalink / raw)
To: qemu-arm; +Cc: qemu-devel, peter.maydell, zhaoshenglong, wu.wubin
From: Shannon Zhao <shannon.zhao@linaro.org>
For example, using -cpu generic will cause qemu segmentation fault.
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
V2: Just remove the member NULL instead of checking twice
---
hw/arm/virt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 7a03f84..95ac585 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -167,7 +167,6 @@ static const char *valid_cpus[] = {
"cortex-a53",
"cortex-a57",
"host",
- NULL
};
static bool cpuname_valid(const char *cpu)
--
2.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] arm: virt: Fix the segmentation fault when specifying an unsupported CPU
2017-01-17 2:15 [Qemu-devel] [PATCH v2] arm: virt: Fix the segmentation fault when specifying an unsupported CPU Shannon Zhao
@ 2017-01-17 11:43 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2017-01-17 11:43 UTC (permalink / raw)
To: Shannon Zhao; +Cc: qemu-arm, QEMU Developers, wu.wubin
On 17 January 2017 at 02:15, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> For example, using -cpu generic will cause qemu segmentation fault.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> V2: Just remove the member NULL instead of checking twice
> ---
> hw/arm/virt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 7a03f84..95ac585 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -167,7 +167,6 @@ static const char *valid_cpus[] = {
> "cortex-a53",
> "cortex-a57",
> "host",
> - NULL
> };
>
> static bool cpuname_valid(const char *cpu)
Applied to target-arm.next (with some expansion of the commit
message), thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-17 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-17 2:15 [Qemu-devel] [PATCH v2] arm: virt: Fix the segmentation fault when specifying an unsupported CPU Shannon Zhao
2017-01-17 11:43 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).