From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, Peter Maydell <peter.maydell@linaro.org>,
Eric Blake <eblake@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v2 2/4] compiler: drop ; after BUILD_BUG_ON
Date: Wed, 18 Jan 2017 22:55:44 +0200 [thread overview]
Message-ID: <1484772931-16272-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1484772931-16272-1-git-send-email-mst@redhat.com>
All users include the trailing ;, let's require that
so that uses such as if (a) QEMU_BUILD_BUG_ON(); do not
produce unexpected results.
Not a huge problem for QEMU since our style requires the use
of {} but seems cleaner nevertheless.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/qemu/compiler.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index 157698b..2882470 100644
--- a/include/qemu/compiler.h
+++ b/include/qemu/compiler.h
@@ -86,7 +86,8 @@
#define type_check(t1,t2) ((t1*)0 - (t2*)0)
#define QEMU_BUILD_BUG_ON(x) \
- typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1] __attribute__((unused));
+ typedef char glue(qemu_build_bug_on__,__LINE__)[(x) ? -1 : 1] \
+ __attribute__((unused))
#if defined __GNUC__
# if !QEMU_GNUC_PREREQ(4, 4)
--
MST
next prev parent reply other threads:[~2017-01-18 20:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 20:55 [Qemu-devel] [PATCH v2 0/4] virtio: ARRAY_SIZE fixups Michael S. Tsirkin
2017-01-18 20:55 ` [Qemu-devel] [PATCH v2 1/4] virtio: fix up max size checks Michael S. Tsirkin
2017-01-19 9:46 ` Cornelia Huck
2017-01-18 20:55 ` Michael S. Tsirkin [this message]
2017-01-18 21:04 ` [Qemu-devel] [PATCH v2 2/4] compiler: drop ; after BUILD_BUG_ON Peter Maydell
2017-01-18 21:16 ` Michael S. Tsirkin
2017-01-18 21:23 ` Michael S. Tsirkin
2017-01-18 21:53 ` Peter Maydell
2017-01-19 8:09 ` Markus Armbruster
2017-01-18 20:55 ` [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON Michael S. Tsirkin
2017-01-19 8:12 ` Markus Armbruster
2017-01-19 10:01 ` Paolo Bonzini
2017-01-19 13:33 ` Markus Armbruster
2017-01-19 19:25 ` Michael S. Tsirkin
2017-01-19 20:58 ` Eric Blake
2017-01-19 21:02 ` Michael S. Tsirkin
2017-01-20 7:21 ` Markus Armbruster
2017-01-20 17:50 ` Michael S. Tsirkin
2017-01-19 21:01 ` Michael S. Tsirkin
2017-01-18 20:55 ` [Qemu-devel] [PATCH v2 4/4] ARRAY_SIZE: check that argument is an array Michael S. Tsirkin
2017-01-19 8:20 ` Markus Armbruster
2017-01-19 11:00 ` Peter Maydell
2017-01-19 14:53 ` Eric Blake
2017-01-19 15:06 ` Michael S. Tsirkin
2017-01-18 21:06 ` [Qemu-devel] [PATCH v2 0/4] virtio: ARRAY_SIZE fixups no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484772931-16272-3-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).