From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTxGo-0003kt-CM for qemu-devel@nongnu.org; Wed, 18 Jan 2017 15:55:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTxGo-0000s1-2a for qemu-devel@nongnu.org; Wed, 18 Jan 2017 15:55:50 -0500 Received: from mail.kernel.org ([198.145.29.136]:56566) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTxGn-0000rL-Sd for qemu-devel@nongnu.org; Wed, 18 Jan 2017 15:55:50 -0500 Date: Wed, 18 Jan 2017 22:55:44 +0200 From: "Michael S. Tsirkin" Message-ID: <1484772931-16272-3-git-send-email-mst@redhat.com> References: <1484772931-16272-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484772931-16272-1-git-send-email-mst@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/4] compiler: drop ; after BUILD_BUG_ON List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Peter Maydell , Eric Blake , Richard Henderson All users include the trailing ;, let's require that so that uses such as if (a) QEMU_BUILD_BUG_ON(); do not produce unexpected results. Not a huge problem for QEMU since our style requires the use of {} but seems cleaner nevertheless. Signed-off-by: Michael S. Tsirkin --- include/qemu/compiler.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 157698b..2882470 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -86,7 +86,8 @@ #define type_check(t1,t2) ((t1*)0 - (t2*)0) #define QEMU_BUILD_BUG_ON(x) \ - typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1] __attribute__((unused)); + typedef char glue(qemu_build_bug_on__,__LINE__)[(x) ? -1 : 1] \ + __attribute__((unused)) #if defined __GNUC__ # if !QEMU_GNUC_PREREQ(4, 4) -- MST