From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com,
jan.kiszka@siemens.com, jasowang@redhat.com, peterx@redhat.com,
alex.williamson@redhat.com, bd.aviv@gmail.com
Subject: [Qemu-devel] [PATCH v5 09/18] intel_iommu: vtd_slpt_level_shift check level
Date: Tue, 24 Jan 2017 18:26:02 +0800 [thread overview]
Message-ID: <1485253571-19058-10-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1485253571-19058-1-git-send-email-peterx@redhat.com>
This helps in debugging incorrect level passed in.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
hw/i386/intel_iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 2c13b7b..6f5f68a 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -168,6 +168,7 @@ static gboolean vtd_hash_remove_by_domain(gpointer key, gpointer value,
/* The shift of an addr for a certain level of paging structure */
static inline uint32_t vtd_slpt_level_shift(uint32_t level)
{
+ assert(level != 0);
return VTD_PAGE_SHIFT_4K + (level - 1) * VTD_SL_LEVEL_BITS;
}
--
2.7.4
next prev parent reply other threads:[~2017-01-24 10:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 10:25 [Qemu-devel] [PATCH v5 00/18] VT-d: vfio enablement and misc enhances Peter Xu
2017-01-24 10:25 ` [Qemu-devel] [PATCH v5 01/18] vfio: trace map/unmap for notify as well Peter Xu
2017-01-24 10:25 ` [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr() Peter Xu
2017-01-24 16:29 ` Alex Williamson
2017-01-25 4:32 ` Peter Xu
2017-01-25 16:43 ` Alex Williamson
2017-01-25 17:16 ` Paolo Bonzini
2017-01-26 6:26 ` Peter Xu
2017-01-25 17:11 ` Paolo Bonzini
2017-01-25 17:36 ` Alex Williamson
2017-01-25 17:40 ` Paolo Bonzini
2017-01-25 18:36 ` Alex Williamson
2017-01-25 19:42 ` Paolo Bonzini
2017-01-25 20:09 ` Alex Williamson
2017-01-26 6:46 ` Peter Xu
2017-01-26 7:12 ` Peter Xu
2017-01-26 10:55 ` Paolo Bonzini
2017-01-26 12:01 ` Peter Xu
2017-01-24 10:25 ` [Qemu-devel] [PATCH v5 03/18] vfio: allow to notify unmap for very large region Peter Xu
2017-01-24 16:32 ` Alex Williamson
2017-01-31 3:35 ` David Gibson
2017-02-03 7:30 ` Peter Xu
2017-01-24 10:25 ` [Qemu-devel] [PATCH v5 04/18] intel_iommu: add "caching-mode" option Peter Xu
2017-01-24 10:25 ` [Qemu-devel] [PATCH v5 05/18] intel_iommu: simplify irq region translation Peter Xu
2017-01-24 10:25 ` [Qemu-devel] [PATCH v5 06/18] intel_iommu: renaming gpa to iova where proper Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 07/18] intel_iommu: fix trace for inv desc handling Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 08/18] intel_iommu: fix trace for addr translation Peter Xu
2017-01-24 10:26 ` Peter Xu [this message]
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 10/18] memory: add section range info for IOMMU notifier Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 11/18] memory: provide IOMMU_NOTIFIER_FOREACH macro Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 12/18] memory: provide iommu_replay_all() Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 13/18] memory: introduce memory_region_notify_one() Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 14/18] memory: add MemoryRegionIOMMUOps.replay() callback Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 15/18] intel_iommu: provide its own replay() callback Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 16/18] intel_iommu: do replay when context invalidate Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 17/18] intel_iommu: allow dynamic switch of IOMMU region Peter Xu
2017-01-24 10:26 ` [Qemu-devel] [PATCH v5 18/18] intel_iommu: enable vfio devices Peter Xu
2017-01-24 11:49 ` [Qemu-devel] [PATCH v5 00/18] VT-d: vfio enablement and misc enhances Peter Xu
2017-01-24 14:48 ` Michael S. Tsirkin
2017-01-25 4:48 ` Peter Xu
2017-01-25 14:26 ` Michael S. Tsirkin
2017-01-26 7:16 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485253571-19058-10-git-send-email-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bd.aviv@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=kevin.tian@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).