From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>,
Li Qiang <liqiang6-s@360.cn>,
qemu-stable@nongnu.org, P J P <ppandit@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] cirrus: fix oob access issue (CVE-2017-TODO)
Date: Wed, 25 Jan 2017 11:44:11 +0100 [thread overview]
Message-ID: <1485341051.29826.105.camel@redhat.com> (raw)
In-Reply-To: <1485328025-3783-1-git-send-email-kraxel@redhat.com>
On Mi, 2017-01-25 at 08:07 +0100, Gerd Hoffmann wrote:
> From: Li Qiang <liqiang6-s@360.cn>
>
> When doing bitblt copy in backward mode, we should minus the
> blt width first just like the adding in the forward mode. This
> can avoid the oob access of the front of vga's vram.
>
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> Message-id: 5887254f.863a240a.2c122.5500@mx.google.com
>
> { kraxel: with backward blits (negative pitch) addr is the topmost
> address, so check it as-is against vram size ]
>
> Cc: qemu-stable@nongnu.org
> Cc: P J P <ppandit@redhat.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Fixes: d3532a0db02296e687711b8cdc7791924efccea0 (CVE-2014-8106)
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
For testers: All pending cirrus fixes are now pushed to:
git://git.kraxel.org/qemu queue/vga
Gerd Hoffmann (1):
cirrus: fix blit address mask handling
Li Qiang (1):
cirrus: fix oob access issue (CVE-2017-TODO)
Wolfgang Bumiller (1):
cirrus: allow zero source pitch in pattern fill rops
cheers,
Gerd
prev parent reply other threads:[~2017-01-25 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 7:07 [Qemu-devel] [PATCH] cirrus: fix oob access issue (CVE-2017-TODO) Gerd Hoffmann
2017-01-25 8:30 ` Wolfgang Bumiller
2017-01-25 9:50 ` Gerd Hoffmann
2017-01-25 10:35 ` Laszlo Ersek
2017-01-25 10:50 ` Wolfgang Bumiller
2017-01-25 10:55 ` Laszlo Ersek
2017-01-25 10:44 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485341051.29826.105.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=pbonzini@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).