Re: [Qemu-devel] [PATCH v2] cirrus: handle negative pitch in cirrus_invalidate_region()

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v2] cirrus: handle negative pitch in cirrus_invalidate_region()
Message-id: 1485352137-29367-1-git-send-email-w.bumiller@proxmox.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1485352082-16830-1-git-send-email-groug@kaod.org -> patchew/1485352082-16830-1-git-send-email-groug@kaod.org
 * [new tag]         patchew/1485352137-29367-1-git-send-email-w.bumiller@proxmox.com -> patchew/1485352137-29367-1-git-send-email-w.bumiller@proxmox.com
 - [tag update]      patchew/20170124110151.937-1-berrange@redhat.com -> patchew/20170124110151.937-1-berrange@redhat.com
 - [tag update]      patchew/20170124180420.12430-1-pbonzini@redhat.com -> patchew/20170124180420.12430-1-pbonzini@redhat.com
Switched to a new branch 'test'
93e5129 cirrus: handle negative pitch in cirrus_invalidate_region()

=== OUTPUT BEGIN ===
Checking PATCH 1/1: cirrus: handle negative pitch in cirrus_invalidate_region()...
ERROR: spaces required around that '-' (ctx:VxV)
#31: FILE: hw/display/cirrus_vga.c:665:
+        off_begin -= bytesperline-1;
                                  ^

ERROR: code indent should never use tabs
#37: FILE: hw/display/cirrus_vga.c:671:
+^Iassert(off_cur_end >= off_cur);$

total: 2 errors, 0 warnings, 14 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org