qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: laurent@vivier.eu
Cc: famz@redhat.com, qemu-devel@nongnu.org, riku.voipio@iki.fi,
	glaubitz@physik.fu-berlin.de
Subject: Re: [Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa
Date: Wed, 25 Jan 2017 12:42:26 -0800 (PST)	[thread overview]
Message-ID: <148537694536.27.11791128628902222733@eba24e3a0d7f> (raw)
In-Reply-To: <20170125203852.19254-1-laurent@vivier.eu>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa
Message-id: 20170125203852.19254-1-laurent@vivier.eu

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20170125203852.19254-1-laurent@vivier.eu -> patchew/20170125203852.19254-1-laurent@vivier.eu
Switched to a new branch 'test'
4995cf7 linux-user: fix "apt-get update" on linux-user hppa
2d71add linux-user: add hppa magic numbers in qemu-binfmt-conf.sh

=== OUTPUT BEGIN ===
Checking PATCH 1/2: linux-user: add hppa magic numbers in qemu-binfmt-conf.sh...
ERROR: line over 90 characters
#33: FILE: scripts/qemu-binfmt-conf.sh:95:
+hppa_magic='\x7f\x45\x4c\x46\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x0f'

ERROR: line over 90 characters
#34: FILE: scripts/qemu-binfmt-conf.sh:96:
+hppa_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 2 errors, 0 warnings, 22 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: linux-user: fix "apt-get update" on linux-user hppa...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  parent reply	other threads:[~2017-01-25 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 20:38 [Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa Laurent Vivier
2017-01-25 20:38 ` [Qemu-devel] [PATCH 1/2] linux-user: add hppa magic numbers in qemu-binfmt-conf.sh Laurent Vivier
2017-01-25 21:25   ` Richard Henderson
2017-01-25 20:38 ` [Qemu-devel] [PATCH 2/2] linux-user: fix "apt-get update" on linux-user hppa Laurent Vivier
2017-01-25 20:45   ` John Paul Adrian Glaubitz
2017-01-25 20:42 ` no-reply [this message]
2017-01-25 20:51   ` [Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148537694536.27.11791128628902222733@eba24e3a0d7f \
    --to=no-reply@patchew.org \
    --cc=famz@redhat.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).