qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Lin Ma <lma@suse.com>
Subject: [Qemu-devel] [PULL 3/3] qmp: Fix argument name in error message of device-list-properties
Date: Fri, 27 Jan 2017 08:29:17 +0100	[thread overview]
Message-ID: <1485502157-25445-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1485502157-25445-1-git-send-email-armbru@redhat.com>

From: Lin Ma <lma@suse.com>

The argument is called "typename", not "name".

[Thanks to Markus for correcting the commit message]

Signed-off-by: Lin Ma <lma@suse.com>
Message-Id: <20170125052703.23571-1-lma@suse.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qmp.c b/qmp.c
index 0028f0b..886059e 100644
--- a/qmp.c
+++ b/qmp.c
@@ -531,12 +531,12 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename,
 
     klass = object_class_dynamic_cast(klass, TYPE_DEVICE);
     if (klass == NULL) {
-        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", TYPE_DEVICE);
+        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", TYPE_DEVICE);
         return NULL;
     }
 
     if (object_class_is_abstract(klass)) {
-        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name",
+        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename",
                    "non-abstract device type");
         return NULL;
     }
-- 
2.7.4

  parent reply	other threads:[~2017-01-27  7:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27  7:29 [Qemu-devel] [PULL 0/3] QAPI/QMP patches for 2017-01-27 Markus Armbruster
2017-01-27  7:29 ` [Qemu-devel] [PULL 1/3] build-sys: Minor qapi doc generation target cleanups Markus Armbruster
2017-01-27  7:29 ` [Qemu-devel] [PULL 2/3] qapi: Remove unwanted commas after #optional keyword Markus Armbruster
2017-01-27  7:29 ` Markus Armbruster [this message]
2017-01-27 16:54 ` [Qemu-devel] [PULL 0/3] QAPI/QMP patches for 2017-01-27 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485502157-25445-4-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=lma@suse.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).