From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: [Qemu-devel] [PATCH 1/3] arm: better stub version for MISMATCH_CHECK
Date: Fri, 27 Jan 2017 18:27:10 +0200 [thread overview]
Message-ID: <1485534415-20887-1-git-send-email-mst@redhat.com> (raw)
stub version of MISMATCH_CHECK is empty so it's easy to misuse for
people not building kvm on arm. Use QEMU_BUILD_BUG_ON similar to the
non-stub version to make it easier to catch bugs.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
target/arm/kvm-consts.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/arm/kvm-consts.h b/target/arm/kvm-consts.h
index a2c9518..06b6c92 100644
--- a/target/arm/kvm-consts.h
+++ b/target/arm/kvm-consts.h
@@ -21,7 +21,9 @@
#define MISMATCH_CHECK(X, Y) QEMU_BUILD_BUG_ON(X != Y)
#else
-#define MISMATCH_CHECK(X, Y)
+
+#define MISMATCH_CHECK(X, Y) QEMU_BUILD_BUG_ON(0)
+
#endif
#define CP_REG_SIZE_SHIFT 52
--
MST
next reply other threads:[~2017-01-27 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 16:27 Michael S. Tsirkin [this message]
2017-01-27 16:27 ` [Qemu-devel] [PATCH 2/3] arm: add trailing ; after MISMATCH_CHECK Michael S. Tsirkin
2017-01-27 16:51 ` Peter Maydell
2017-01-27 16:27 ` [Qemu-devel] [PATCH 3/3] ppc: switch to constants within BUILD_BUG_ON Michael S. Tsirkin
2017-01-31 2:55 ` David Gibson
2017-01-27 16:50 ` [Qemu-devel] [PATCH 1/3] arm: better stub version for MISMATCH_CHECK Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485534415-20887-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).