qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Cao jin <caoj.fnst@cn.fujitsu.com>,
	Markus Armbruster <armbru@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>
Subject: [Qemu-devel] [PULL v3 13/21] msix: Follow CODING_STYLE
Date: Tue, 31 Jan 2017 15:14:54 +0200	[thread overview]
Message-ID: <1485868446-10587-14-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1485868446-10587-1-git-send-email-mst@redhat.com>

From: Cao jin <caoj.fnst@cn.fujitsu.com>

CC: Markus Armbruster <armbru@redhat.com>
CC: Marcel Apfelbaum <marcel@redhat.com>
CC: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/pci/msix.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index ee1714d..c938a9b 100644
--- a/hw/pci/msix.c
+++ b/hw/pci/msix.c
@@ -447,8 +447,10 @@ void msix_notify(PCIDevice *dev, unsigned vector)
 {
     MSIMessage msg;
 
-    if (vector >= dev->msix_entries_nr || !dev->msix_entry_used[vector])
+    if (vector >= dev->msix_entries_nr || !dev->msix_entry_used[vector]) {
         return;
+    }
+
     if (msix_is_masked(dev, vector)) {
         msix_set_pending(dev, vector);
         return;
@@ -483,8 +485,10 @@ void msix_reset(PCIDevice *dev)
 /* Mark vector as used. */
 int msix_vector_use(PCIDevice *dev, unsigned vector)
 {
-    if (vector >= dev->msix_entries_nr)
+    if (vector >= dev->msix_entries_nr) {
         return -EINVAL;
+    }
+
     dev->msix_entry_used[vector]++;
     return 0;
 }
-- 
MST

  parent reply	other threads:[~2017-01-31 13:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 13:14 [Qemu-devel] [PULL v3 00/21] virtio, vhost, pci: fixes, features Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 01/21] compiler: drop ; after BUILD_BUG_ON Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 02/21] qxl: switch to constants within BUILD_BUG_ON Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 03/21] ppc: " Michael S. Tsirkin
2017-01-31 22:16   ` David Gibson
2017-02-01  1:37     ` Michael S. Tsirkin
2017-02-01  2:25       ` David Gibson
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 04/21] compiler: rework BUG_ON using a struct Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 05/21] compiler: expression version of QEMU_BUILD_BUG_ON Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 06/21] ARRAY_SIZE: check that argument is an array Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 07/21] pci: mark ROMs read-only Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 08/21] intel_iommu: fix and simplify size calculation in process_device_iotlb_desc() Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 09/21] hw/pcie: Introduce a base class for PCI Express Root Ports Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 10/21] hw/ioh3420: derive from PCI Express Root Port base class Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 11/21] hw/pcie: Introduce Generic PCI Express Root Port Michael S. Tsirkin
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 12/21] hw/i386: check if nvdimm is enabled before plugging Michael S. Tsirkin
2017-01-31 13:14 ` Michael S. Tsirkin [this message]
2017-01-31 13:14 ` [Qemu-devel] [PULL v3 14/21] hcd-xhci: check & correct param before using it Michael S. Tsirkin
2017-01-31 13:15 ` [Qemu-devel] [PULL v3 15/21] pci: Convert msix_init() to Error and fix callers Michael S. Tsirkin
2017-01-31 13:15 ` [Qemu-devel] [PULL v3 16/21] virtio: make virtio_should_notify static Michael S. Tsirkin
2017-01-31 13:15 ` [Qemu-devel] [PULL v3 17/21] vhost: skip ROM sections Michael S. Tsirkin
2017-01-31 13:15 ` [Qemu-devel] [PULL v3 18/21] vhost-user: delete chardev on cleanup Michael S. Tsirkin
2017-01-31 13:15 ` [Qemu-devel] [PULL v3 19/21] hw/pci: disable pci-bridge's shpc by default Michael S. Tsirkin
2017-01-31 13:15 ` [Qemu-devel] [PULL v3 20/21] arm: better stub version for MISMATCH_CHECK Michael S. Tsirkin
2017-01-31 13:15 ` [Qemu-devel] [PULL v3 21/21] arm: add trailing ; after MISMATCH_CHECK Michael S. Tsirkin
2017-01-31 13:24 ` [Qemu-devel] [PULL v3 00/21] virtio, vhost, pci: fixes, features Peter Maydell
2017-01-31 14:01   ` Michael S. Tsirkin
2017-01-31 14:10   ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485868446-10587-14-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=armbru@redhat.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=marcel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).