From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYuqE-0005wg-0V for qemu-devel@nongnu.org; Wed, 01 Feb 2017 08:20:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cYuq9-0006Ta-Uk for qemu-devel@nongnu.org; Wed, 01 Feb 2017 08:20:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54814) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cYuq9-0006Sl-PB for qemu-devel@nongnu.org; Wed, 01 Feb 2017 08:20:49 -0500 Message-ID: <1485955246.1076.55.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 01 Feb 2017 14:20:46 +0100 In-Reply-To: <001001d27bbe$2770c3f0$76524bd0$@ru> References: <20170131115913.6828.12266.stgit@PASHA-ISP> <001001d27bbe$2770c3f0$76524bd0$@ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk Cc: =?ISO-8859-1?Q?=27Marc-Andr=E9?= Lureau' , 'Pavel Dovgalyuk' , qemu-devel@nongnu.org, pbonzini@redhat.com On Di, 2017-01-31 at 15:32 +0300, Pavel Dovgalyuk wrote: > This patch is needed to make this timer deterministic and to use > execution record/replay >=20 > for audio devices. >=20 > =20 >=20 > audio_reset_timer is used in the function > audio_vm_change_state_handler. >=20 > Therefore every time VM is stopped or restarted the timer will be > reset to new timeout. >=20 > Virtual clock does not proceed while VM is stopped. Therefore there is > no need >=20 > in resetting the timeout when VM restarts. Add that to the commit message please. cheers, Gerd