From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] audio/sdlaudio: Allow audio playback with SDL2
Date: Wed, 01 Feb 2017 14:25:13 +0100 [thread overview]
Message-ID: <1485955513.1076.59.camel@redhat.com> (raw)
In-Reply-To: <1485852398-2327-1-git-send-email-thuth@redhat.com>
On Di, 2017-01-31 at 09:46 +0100, Thomas Huth wrote:
> When compiling with SDL2, the semaphore trick used in sdlaudio.c
> does not work - QEMU locks up completely in this case. To avoid
> the hang and get at least some audio playback up and running (it's
> a little bit crackling, but better than nothing), we can use the
> SDL locking functions SDL_LockAudio() and SDL_UnlockAudio() to sync
> with the sound playback thread instead.
Does SDL_LockAudio work with sdl1 too?
So we can possibly avoid having all those #ifdefs?
cheers,
Gerd
next prev parent reply other threads:[~2017-02-01 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 8:46 [Qemu-devel] [RFC PATCH] audio/sdlaudio: Allow audio playback with SDL2 Thomas Huth
2017-02-01 13:25 ` Gerd Hoffmann [this message]
2017-02-01 15:30 ` Thomas Huth
2017-02-16 15:14 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485955513.1076.59.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).