From: Gerd Hoffmann <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, Li Qiang <liqiang6-s@360.cn>,
qemu-stable@nongnu.org, P J P <ppandit@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [Qemu-devel] [PULL 4/4] cirrus: fix oob access issue (CVE-2017-2615)
Date: Thu, 02 Feb 2017 16:00:12 +0100 [thread overview]
Message-ID: <1486047612.20628.44.camel@redhat.com> (raw)
In-Reply-To: <43557bc0-30ba-fab8-2378-b7ab912e6c84@redhat.com>
> > Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > Message-id: 1485938101-26602-1-git-send-email-kraxel@redhat.com
> > Message-id: 5887254f.863a240a.2c122.5500@mx.google.com
> >
> > { kraxel: with backward blits (negative pitch) addr is the topmost
> > address, so check it as-is against vram size ]
> >
> > Cc: qemu-stable@nongnu.org
> > Cc: P J P <ppandit@redhat.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
> > Fixes: d3532a0db02296e687711b8cdc7791924efccea0 (CVE-2014-8106)
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> My inner pedant wishes to observe that my review concerned the patch as
> modified by you, so for complete accuracy, my R-b should be at the
> bottom, under your S-o-b.
>
> Not sure if this merits a PULLv2, I just needed to "silence to voices".
Oops. The message ids are kinda f*cked up too. Guess I shouldn't trust
the patches tool too much when it comes to non-trivial patch flows.
I'll respin the pull request.
cheers,
Gerd
next prev parent reply other threads:[~2017-02-02 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 8:23 [Qemu-devel] [PULL 0/4] cirrus: multiple bugfixes, including CVE-2017-2615 fix Gerd Hoffmann
2017-02-02 8:23 ` [Qemu-devel] [PULL 1/4] cirrus: handle negative pitch in cirrus_invalidate_region() Gerd Hoffmann
2017-02-02 8:23 ` [Qemu-devel] [PULL 2/4] cirrus: allow zero source pitch in pattern fill rops Gerd Hoffmann
2017-02-02 8:23 ` [Qemu-devel] [PULL 3/4] cirrus: fix blit address mask handling Gerd Hoffmann
2017-02-02 8:23 ` [Qemu-devel] [PULL 4/4] cirrus: fix oob access issue (CVE-2017-2615) Gerd Hoffmann
2017-02-02 10:14 ` Laszlo Ersek
2017-02-02 15:00 ` Gerd Hoffmann [this message]
2017-02-02 15:00 ` [Qemu-devel] [PULL 0/4] cirrus: multiple bugfixes, including CVE-2017-2615 fix Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2017-02-02 15:05 Gerd Hoffmann
2017-02-02 15:05 ` [Qemu-devel] [PULL 4/4] cirrus: fix oob access issue (CVE-2017-2615) Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486047612.20628.44.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=pbonzini@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).