From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, 1653384@bugs.launchpad.net
Subject: [Qemu-devel] [PULL 4/9] xhci: only free completed transfers
Date: Mon, 6 Feb 2017 12:28:16 +0100 [thread overview]
Message-ID: <1486380501-13431-5-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1486380501-13431-1-git-send-email-kraxel@redhat.com>
Most callsites check already, one was missed.
Cc: 1653384@bugs.launchpad.net
Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55
Reported-by: Fabian Lesniak <fabian@lesniak-it.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 1485790607-31399-2-git-send-email-kraxel@redhat.com
---
hw/usb/hcd-xhci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index f810678..6a1d3dc 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2198,7 +2198,9 @@ static void xhci_kick_epctx(XHCIEPContext *epctx, unsigned int streamid)
xhci_complete_packet(xfer);
}
assert(!xfer->running_retry);
- xhci_ep_free_xfer(epctx->retry);
+ if (xfer->complete) {
+ xhci_ep_free_xfer(epctx->retry);
+ }
epctx->retry = NULL;
}
--
1.8.3.1
next prev parent reply other threads:[~2017-02-06 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 11:28 [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci Gerd Hoffmann
2017-02-06 11:28 ` [Qemu-devel] [PULL 1/9] hw/usb/dev-hid: Improve guest compatibility of usb-tablet Gerd Hoffmann
2017-02-06 11:28 ` [Qemu-devel] [PULL 2/9] usb/uas: more verbose error message Gerd Hoffmann
2017-02-06 11:28 ` [Qemu-devel] [PULL 3/9] usb: accept usb3 control requests Gerd Hoffmann
2017-02-06 11:28 ` Gerd Hoffmann [this message]
2017-02-06 11:28 ` [Qemu-devel] [PULL 5/9] xhci: rename xhci_complete_packet to xhci_try_complete_packet Gerd Hoffmann
2017-02-06 11:28 ` [Qemu-devel] [PULL 6/9] xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer Gerd Hoffmann
2017-02-06 11:28 ` [Qemu-devel] [PULL 7/9] xhci: guard xhci_kick_epctx against recursive calls Gerd Hoffmann
2017-02-06 11:28 ` [Qemu-devel] [PULL 8/9] usb: ccid: check ccid apdu length Gerd Hoffmann
2017-02-06 11:28 ` [Qemu-devel] [PULL 9/9] xhci: fix event queue IRQ handling Gerd Hoffmann
2017-02-06 11:42 ` [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci no-reply
2017-02-06 12:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486380501-13431-5-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=1653384@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).