From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com,
jan.kiszka@siemens.com, jasowang@redhat.com, peterx@redhat.com,
David Gibson <david@gibson.dropbear.id.au>,
alex.williamson@redhat.com, bd.aviv@gmail.com
Subject: [Qemu-devel] [PATCH v7 09/17] intel_iommu: vtd_slpt_level_shift check level
Date: Tue, 7 Feb 2017 16:28:11 +0800 [thread overview]
Message-ID: <1486456099-7345-10-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1486456099-7345-1-git-send-email-peterx@redhat.com>
This helps in debugging incorrect level passed in.
Reviewed-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
hw/i386/intel_iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index ad304f6..22d8226 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -168,6 +168,7 @@ static gboolean vtd_hash_remove_by_domain(gpointer key, gpointer value,
/* The shift of an addr for a certain level of paging structure */
static inline uint32_t vtd_slpt_level_shift(uint32_t level)
{
+ assert(level != 0);
return VTD_PAGE_SHIFT_4K + (level - 1) * VTD_SL_LEVEL_BITS;
}
--
2.7.4
next prev parent reply other threads:[~2017-02-07 8:29 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 8:28 [Qemu-devel] [PATCH v7 00/17] VT-d: vfio enablement and misc enhances Peter Xu
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 01/17] vfio: trace map/unmap for notify as well Peter Xu
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 02/17] vfio: introduce vfio_get_vaddr() Peter Xu
2017-02-10 1:12 ` David Gibson
2017-02-10 5:50 ` Peter Xu
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 03/17] vfio: allow to notify unmap for very large region Peter Xu
2017-02-10 1:13 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 04/17] intel_iommu: add "caching-mode" option Peter Xu
2017-02-10 1:14 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 05/17] intel_iommu: simplify irq region translation Peter Xu
2017-02-10 1:15 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 06/17] intel_iommu: renaming gpa to iova where proper Peter Xu
2017-02-10 1:17 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 07/17] intel_iommu: convert dbg macros to traces for inv Peter Xu
2017-02-08 2:47 ` Jason Wang
2017-02-10 1:19 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 08/17] intel_iommu: convert dbg macros to trace for trans Peter Xu
2017-02-08 2:49 ` Jason Wang
2017-02-10 1:20 ` David Gibson
2017-02-07 8:28 ` Peter Xu [this message]
2017-02-10 1:20 ` [Qemu-devel] [PATCH v7 09/17] intel_iommu: vtd_slpt_level_shift check level David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 10/17] memory: add section range info for IOMMU notifier Peter Xu
2017-02-10 2:29 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 11/17] memory: provide IOMMU_NOTIFIER_FOREACH macro Peter Xu
2017-02-10 2:30 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 12/17] memory: provide iommu_replay_all() Peter Xu
2017-02-10 2:31 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 13/17] memory: introduce memory_region_notify_one() Peter Xu
2017-02-10 2:33 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback Peter Xu
2017-02-10 2:34 ` David Gibson
2017-03-27 8:35 ` Liu, Yi L
2017-03-27 9:12 ` Peter Xu
2017-03-27 9:21 ` Liu, Yi L
2017-03-30 11:06 ` Liu, Yi L
2017-03-30 11:57 ` Jason Wang
2017-03-31 2:56 ` Peter Xu
2017-03-31 4:21 ` Jason Wang
2017-03-31 5:01 ` Peter Xu
2017-03-31 5:12 ` Jason Wang
2017-03-31 5:28 ` Peter Xu
2017-03-31 5:34 ` Liu, Yi L
2017-03-31 7:16 ` Jason Wang
2017-03-31 7:30 ` Liu, Yi L
2017-04-01 5:00 ` Jason Wang
2017-04-01 6:39 ` Liu, Yi L
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 15/17] intel_iommu: provide its own replay() callback Peter Xu
2017-02-10 2:36 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 16/17] intel_iommu: allow dynamic switch of IOMMU region Peter Xu
2017-02-10 2:38 ` David Gibson
2017-02-07 8:28 ` [Qemu-devel] [PATCH v7 17/17] intel_iommu: enable vfio devices Peter Xu
2017-02-10 6:24 ` Jason Wang
2017-03-16 4:05 ` Peter Xu
2017-03-19 15:34 ` Aviv B.D.
2017-03-20 1:56 ` Peter Xu
2017-03-20 2:12 ` Liu, Yi L
2017-03-20 2:41 ` Peter Xu
2017-02-17 17:18 ` [Qemu-devel] [PATCH v7 00/17] VT-d: vfio enablement and misc enhances Alex Williamson
2017-02-20 7:47 ` Peter Xu
2017-02-20 8:17 ` Liu, Yi L
2017-02-20 8:32 ` Peter Xu
2017-02-20 19:15 ` Alex Williamson
2017-02-28 7:52 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486456099-7345-10-git-send-email-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bd.aviv@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=kevin.tian@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).