From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 0/2] Flatten simple unions where we still can
Date: Wed, 8 Feb 2017 17:04:22 +0100 [thread overview]
Message-ID: <1486569864-17005-1-git-send-email-armbru@redhat.com> (raw)
Simple unions are simpler than flat unions in the schema, but more
complicated in C and on the QMP wire: there's extra indirection in C
and extra nesting on the wire, both pointless. They're best avoided
in new code.
But we can do more: we can flatten the simple unions that aren't used
in QMP.
In the longer run, I'd love to get rid of simple unions entirely, and
reduce the notational overhead of flat unions in the schema.
Markus Armbruster (2):
numa: Turn simple union NumaOptions into a flat union
net: Turn simple union NetLegacyOptions into a flat union
net/net.c | 44 ++++++++++++++++++++++----------------------
numa.c | 4 ++--
qapi-schema.json | 17 +++++++++++++++++
3 files changed, 41 insertions(+), 24 deletions(-)
--
2.7.4
next reply other threads:[~2017-02-08 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 16:04 Markus Armbruster [this message]
2017-02-08 16:04 ` [Qemu-devel] [PATCH 1/2] numa: Turn simple union NumaOptions into a flat union Markus Armbruster
2017-02-08 19:21 ` Eric Blake
2017-02-09 7:26 ` Markus Armbruster
2017-02-08 16:04 ` [Qemu-devel] [PATCH 2/2] net: Turn simple union NetLegacyOptions " Markus Armbruster
2017-02-08 19:22 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486569864-17005-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).