From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbWVH-0001rV-2N for qemu-devel@nongnu.org; Wed, 08 Feb 2017 12:58:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbWVE-000491-1s for qemu-devel@nongnu.org; Wed, 08 Feb 2017 12:58:03 -0500 From: Thomas Huth Date: Wed, 8 Feb 2017 18:57:49 +0100 Message-Id: <1486576669-29760-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH v3] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Markus Armbruster The "or-irq" device needs to be wired up in source code, there is no way the user can make any real use of this device with the "-device" parameter or the "device_add" monitor command yet. Signed-off-by: Thomas Huth --- v3: Another update to the patch description and comment hw/core/or-irq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c index 1ac090d..1485d5b 100644 --- a/hw/core/or-irq.c +++ b/hw/core/or-irq.c @@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data) dc->props = or_irq_properties; dc->realize = or_irq_realize; dc->vmsd = &vmstate_or_irq; + + /* Reason: Needs to be wired up to work, e.g. see stm32f205_soc.c */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo or_irq_type_info = { -- 1.8.3.1